Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build nightly binaries of odo and make them available (via IBM Cloud Object Storage) #6875

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Build nightly binaries of odo and make them available (via IBM Cloud Object Storage) #6875

merged 5 commits into from
Jun 13, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jun 9, 2023 •
edited
Loading

What type of PR is this:
/kind feature

What does this PR do / why we need it:
This adds a scheduled GitHub Workflow that builds odo for multiple platforms, and uploads those binaries to IBM Cloud Storage, so users can consume them.

Which issue(s) this PR fixes:
Fixes #6693

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Example of job in action: https://github.com/rm3l/odo/actions/runs/5220887665/jobs/9424500936

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 9, 2023
@netlify
Copy link

netlify bot commented Jun 9, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit b6c7777
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64886664cfcc520008d5bfe7

@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 9, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 3ad077c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

NoCluster Tests on commit 3ad077c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

Unit Tests on commit 3ad077c finished successfully.
View logs: TXT HTML

@rm3l rm3l added the area/release-eng Issues or PRs related to the Release Engineering label Jun 9, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

Validate Tests on commit 3ad077c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

Kubernetes Tests on commit 3ad077c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

OpenShift Tests on commit 3ad077c finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

Windows Tests (OCP) on commit 3ad077c finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 6bc3011 finished with errors.
View logs: TXT HTML

@rm3l
Add a '-nightly' suffix to the commit id included at build time
10fc824 
This will help users running 'odo' know
that they are running a nightly build, e.g.:

```
$ ./odo version
odo v3.11.0 (077397d-nightly)
```
@rm3l rm3l changed the title [WIP] Build nightly binaries of odo and upload them to IBM Cloud Object Storage Build nightly binaries of odo and upload them to IBM Cloud Object Storage Jun 9, 2023
@rm3l rm3l changed the title Build nightly binaries of odo and upload them to IBM Cloud Object Storage Build nightly binaries of odo and make them available (via IBM Cloud Object Storage) Jun 9, 2023
@rm3l rm3l marked this pull request as ready for review June 9, 2023 10:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 9, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and kadel June 9, 2023 10:52
@rm3l rm3l mentioned this pull request Jun 9, 2023
Closed
@rm3l rm3l removed the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 9, 2023
@rm3l @feloy
Use an arbitrary cron schedule in the night to avoid peak executions …
b6c7777 
…at midnight

Co-authored-by: Philippe Martin <contact@elol.fr>
@rm3l rm3l requested a review from feloy June 13, 2023 12:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 13, 2023
@rm3l
Copy link
Member Author

rm3l commented Jun 13, 2023 

<< Timeline

  [FAILED] registry_list_output.mdx
  Expected
      <string>:   strings.Join({
        	... // 108 identical bytes
        	"                        VERSIONS\nnodejs-react  StagingRegistry  ",
        	"       React is a free and open-source front-en...  2.0.2, 2.1.0",
      + 	", 2.2.0",
        	"\nnodejs-react  DefaultDevfileRegistry  React is a free and open-",
        	"source front-en...  2.0.2, 2.1.0\n```\n",
        }, "")
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/13/23 13:29:19.777
------------------------------
Spawning '/go/bin/odo init' from /tmp/3783843539
••Spawning '/go/bin/odo delete project odo-dev' from /tmp/515641760
•••

Summarizing 1 Failure:
  [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
  /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Ran 16 of 16 Specs in 45.715 seconds
FAIL! -- 15 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestDocCommandReferenceAutomation (45.74s)
FAIL

PR not related to this failure, which has been reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

<< Timeline

 [FAILED] registry_list_output.mdx
 Expected
     <string>:   strings.Join({
       	... // 108 identical bytes
       	"                        VERSIONS\nnodejs-react  StagingRegistry  ",
       	"       React is a free and open-source front-en...  2.0.2, 2.1.0",
     + 	", 2.2.0",
       	"\nnodejs-react  DefaultDevfileRegistry  React is a free and open-",
       	"source front-en...  2.0.2, 2.1.0\n```\n",
       }, "")
     
 to be empty
 In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/13/23 13:29:19.777
------------------------------
Spawning '/go/bin/odo init' from /tmp/3783843539
••Spawning '/go/bin/odo delete project odo-dev' from /tmp/515641760
•••

Summarizing 1 Failure:
 [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
 /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Ran 16 of 16 Specs in 45.715 seconds
FAIL! -- 15 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestDocCommandReferenceAutomation (45.74s)
FAIL

PR not related to this failure, which has been reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Jun 13, 2023 

  [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4147/tests/helper/helper_filesystem.go:45 @ 06/13/23 08:26:37.685
  << Timeline

  [FAILED] Expected
      <*url.Error | 0xc0008e0660>: {
          Op: "Post",
          URL: "http://127.0.0.1:59801/api/newuser",
          Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4147/tests/e2escenarios/e2e_test.go:431 @ 06/13/23 08:24:31.282

E2E test - reported in #6582

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

 [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4147/tests/helper/helper_filesystem.go:45 @ 06/13/23 08:26:37.685
 << Timeline

 [FAILED] Expected
     <*url.Error | 0xc0008e0660>: {
         Op: "Post",
         URL: "http://127.0.0.1:59801/api/newuser",
         Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4147/tests/e2escenarios/e2e_test.go:431 @ 06/13/23 08:24:31.282

E2E test - reported in #6582

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Jun 13, 2023

Not related.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

Not related.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 57da760 into redhat-developer:main Jun 13, 2023
@rm3l rm3l deleted the 6693-setup-nightly-odo-binary-builds branch June 13, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@kadel kadel Awaiting requested review from kadel

Assignees

@feloy feloy

Labels
area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup nightly odo binary builds
3 participants
@rm3l @feloy @openshift-merge-robot