-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podman version to odo version output #6913
Add podman version to odo version output #6913
Conversation
🔨 Deploy Preview deleted from internal cluster!
|
0d5932d
to
0acf1a5
Compare
011b722
to
ea2d256
Compare
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment about the --client
option: we are displaying warnings when a user specifies --client
, but I think this can be quite confusing.
$ odo version --client
⚠ unable to fetch the cluster server version
⚠ unable to fetch the podman client version
odo v3.11.0 (8e0cd5a80)
As a user, I'd expect to not even check Podman and clusters, so I think we should not display those warnings, no?
Not sure why, but the Podman tests consistently fail on GitHub with the same error: This was the first time I saw this kind of error.. I noticed the same error on other PRs as well, like with #6924 (https://github.com/redhat-developer/odo/actions/runs/5344975468/jobs/9690029602) |
@valaparthvi Can you rebase your branch onto |
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
fb6adf1
to
93618eb
Compare
New changes are detected. LGTM label has been removed. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Unrelated. /override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests |
@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This PR adds podman version (if available) to the
odo version
output.Which issue(s) this PR fixes:
Fixes #6806
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: