Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch for new pods when logs --follow #6914

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Watch for new pods when logs --follow #6914

merged 4 commits into from
Jun 28, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 19, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6058

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 19, 2023
@netlify
Copy link

netlify bot commented Jun 19, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 23c1068
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/649abc416a93f500081ad2fb

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 19, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

NoCluster Tests on commit f90178f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit f90178f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Unit Tests on commit f90178f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Validate Tests on commit f90178f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 19, 2023 •
edited
Loading

Windows Tests (OCP) on commit f90178f finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 20, 2023 •
edited
Loading

Kubernetes Tests on commit f90178f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 20, 2023 •
edited
Loading

OpenShift Tests on commit f90178f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 20, 2023 •
edited
Loading

Kubernetes Docs Tests on commit c8a1414 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6058/logs-follow branch 5 times, most recently from 6eec263 to d02eb88 Compare June 25, 2023 18:32
@feloy feloy changed the title [wip] Watch for new pods when logs --follow Watch for new pods when logs --follow Jun 26, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 26, 2023
@feloy feloy requested review from rm3l and removed request for anandrkskd June 26, 2023 07:58
@feloy feloy changed the title Watch for new pods when logs --follow [wip] Watch for new pods when logs --follow Jun 26, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 26, 2023
@feloy feloy changed the title [wip] Watch for new pods when logs --follow Watch for new pods when logs --follow Jun 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 27, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 28, 2023
@feloy feloy closed this Jun 28, 2023
@feloy feloy reopened this Jun 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.9% 12.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@feloy
Copy link
Contributor Author

feloy commented Jun 28, 2023

/override windows-integration-test/Windows-test

odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] should serve endpoints
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4281/tests/integration/cmd_dev_api_server_test.go:87
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4281/tests/integration/cmd_dev_api_server_test.go:101
[...]
Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] should serve endpoints
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4281/tests/integration/cmd_dev_api_server_test.go:87
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4281/tests/integration/cmd_dev_api_server_test.go:101
[...]
Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jun 28, 2023

/override "SonarCloud Code Analysis"

Duplicate code on Mocks

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

@feloy: Overrode contexts on behalf of feloy: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Duplicate code on Mocks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f276d0d into redhat-developer:main Jun 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo logs --follow should not break if no containers are running
3 participants
@feloy @rm3l @openshift-merge-robot