Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR for v3.12.0 #6936

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Release PR for v3.12.0 #6936

merged 6 commits into from
Jul 10, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 27, 2023 •
edited by rm3l
Loading

/area documentation
/area release-eng
/hold

PR for new release: v3.12.0

Fixes #6878

Blog post: https://odo-dev-pr-6936.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/blog/odo-v3.12.0

NOTE: The v3.12.0 binaries are not available yet (due to #6878 (comment)), but the content of the blog post can be reviewed.

EDIT (Jul 10, 2023): Binaries are now available.

@github-actions github-actions bot requested a review from rm3l June 27, 2023 18:08
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Jun 27, 2023
@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited by github-actions bot
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 81a992a
😎 Deploy Preview https://odo-dev-pr-6936.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot added area/release-eng Issues or PRs related to the Release Engineering needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Jun 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2023

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

NoCluster Tests on commit bd1ca6a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit bd1ca6a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

Unit Tests on commit bd1ca6a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

Validate Tests on commit bd1ca6a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

Kubernetes Tests on commit bd1ca6a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

Windows Tests (OCP) on commit bd1ca6a finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

OpenShift Tests on commit bd1ca6a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 27, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 649181c finished successfully.
View logs: TXT HTML

rm3l added 2 commits July 3, 2023 18:04
@rm3l
Fix order of "Using Helm with odo" blog post when there is no Git his…
e884a88 
…tory

This was the case when running developing on the website with `odo dev`
@rm3l
Update release blog post content
bb232f7
@rm3l rm3l temporarily deployed to internal July 3, 2023 16:05 — with GitHub Actions Inactive
@rm3l rm3l changed the title [WIP] Release PR for v3.12.0 Release PR for v3.12.0 Jul 5, 2023
@rm3l rm3l added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Jul 5, 2023
@rm3l rm3l marked this pull request as ready for review July 5, 2023 09:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 5, 2023
@rm3l rm3l temporarily deployed to internal July 5, 2023 09:17 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot requested review from feloy and valaparthvi July 5, 2023 09:17
@rm3l rm3l removed request for rm3l and valaparthvi July 5, 2023 09:17
@rm3l
Copy link
Member

rm3l commented Jul 5, 2023

/hold

The v3.12.0 binaries are not available yet (due to #6878 (comment)), but the content of the blog post can be reviewed.

feloy
feloy reviewed Jul 5, 2023
View reviewed changes
docs/website/blog/2023-06-27-odo-v3.12.0.md Outdated Show resolved Hide resolved
docs/website/blog/2023-06-27-odo-v3.12.0.md Outdated Show resolved Hide resolved
@rm3l @feloy
Apply suggestions from code review
81a992a 
Co-authored-by: Philippe Martin <phmartin@redhat.com>
@rm3l rm3l temporarily deployed to internal July 5, 2023 09:33 — with GitHub Actions Inactive
@rm3l rm3l requested a review from feloy July 5, 2023 09:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 5, 2023
@rm3l
Copy link
Member

rm3l commented Jul 5, 2023 

...
  [odo] I0705 05:13:02.797947    1156 starterserver.go:78] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
...
Summarizing 2 Failures:
  [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] should serve endpoints
  C:/Users/Administrator.ANSIBLE-TEST-VS/4315/tests/helper/helper_run.go:50
  [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag (custom api server port=false) [BeforeEach] should start the Dev server when --api-server flag is passed
  C:/Users/Administrator.ANSIBLE-TEST-VS/4315/tests/helper/helper_run.go:50

Ran 378 of 932 Specs in 1266.531 seconds
FAIL! -- 376 Passed | 2 Failed | 0 Pending | 554 Skipped

Port binding issues on Windows - reported in #6939. Not related to this PR.

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

...
 [odo] I0705 05:13:02.797947    1156 starterserver.go:78] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
...
Summarizing 2 Failures:
 [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] should serve endpoints
 C:/Users/Administrator.ANSIBLE-TEST-VS/4315/tests/helper/helper_run.go:50
 [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag (custom api server port=false) [BeforeEach] should start the Dev server when --api-server flag is passed
 C:/Users/Administrator.ANSIBLE-TEST-VS/4315/tests/helper/helper_run.go:50

Ran 378 of 932 Specs in 1266.531 seconds
FAIL! -- 376 Passed | 2 Failed | 0 Pending | 554 Skipped

Port binding issues on Windows - reported in #6939. Not related to this PR.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Jul 10, 2023

/hold cancel

Binaries for v3.12.0 seem to be available on the Content Gateway. Removing the hold so that we can proceed with the release announcement.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jul 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit bc16851 into main Jul 10, 2023
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal July 10, 2023 12:18 — with GitHub Actions Inactive
@rm3l rm3l deleted the release_pr_v3.12.0 branch July 10, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l left review comments

@feloy feloy feloy approved these changes

Assignees

@feloy feloy

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎉 Release for Sprints 239 through 240 (v3.12.0) 🎉
3 participants
@rm3l @feloy @openshift-merge-robot