Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve UI from api server #6954

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Serve UI from api server #6954

merged 6 commits into from
Jul 7, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 6, 2023 •
edited
Loading

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6934

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jul 6, 2023
@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c616343
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64a7ddeb83cb2d000846eb78

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 6, 2023
@openshift-ci openshift-ci bot requested review from kadel and valaparthvi July 6, 2023 08:50
@feloy feloy force-pushed the feature-6934/serve-ui branch 2 times, most recently from 9632c7d to f2a33f7 Compare July 6, 2023 08:55
@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 2cff5d3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

NoCluster Tests on commit 2cff5d3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

Unit Tests on commit 2cff5d3 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6934/serve-ui branch from f2a33f7 to adfcceb Compare July 6, 2023 09:04
@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

Validate Tests on commit 2cff5d3 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6934/serve-ui branch 3 times, most recently from 4783829 to fad348f Compare July 6, 2023 09:17
@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

Kubernetes Tests on commit 2cff5d3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

Windows Tests (OCP) on commit 2cff5d3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 2c3d2ea finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 6, 2023 •
edited
Loading

OpenShift Tests on commit 2cff5d3 finished with errors.
View logs: TXT HTML

@feloy feloy changed the title [wip] Serve UI from api server Serve UI from api server Jul 6, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 6, 2023
@feloy feloy force-pushed the feature-6934/serve-ui branch 2 times, most recently from 1c3c7e0 to 35b4fe9 Compare July 6, 2023 15:17
@feloy feloy force-pushed the feature-6934/serve-ui branch from 35b4fe9 to e20d934 Compare July 6, 2023 16:40
@feloy feloy requested review from rm3l and removed request for kadel and valaparthvi July 6, 2023 18:27
@feloy feloy force-pushed the feature-6934/serve-ui branch 3 times, most recently from e14585f to 6ef422a Compare July 7, 2023 06:53
rm3l
rm3l reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, same point already mentioned before: can you add the generated pkg/apiserver-impl/ui to the .gitattributes file?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 7, 2023
@feloy
Copy link
Contributor Author

feloy commented Jul 7, 2023

/override ODO-PODMAN-TEST

 [FAILED] [91.208 seconds]
2023-07-07T09:47:22.5397480Z odo dev command tests when using devfile that contains K8s resource to run it on podman [It] should build the images when running odo dev on podman [podman]
2023-07-07T09:47:22.5398324Z /home/runner/work/odo/odo/tests/integration/cmd_dev_test.go:3710
[...]
2023-07-07T09:47:22.6078901Z   [odo] error starting container da1851b2f8e4d5a78ec3569ad8f4d627b96c694ba2d12366e5f1853558f05510: rootlessport listen tcp 127.0.0.1:24481: bind: address already in use

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

@feloy: Overrode contexts on behalf of feloy: ODO-PODMAN-TEST

In response to this:

/override ODO-PODMAN-TEST

[FAILED] [91.208 seconds]
2023-07-07T09:47:22.5397480Z odo dev command tests when using devfile that contains K8s resource to run it on podman [It] should build the images when running odo dev on podman [podman]
2023-07-07T09:47:22.5398324Z /home/runner/work/odo/odo/tests/integration/cmd_dev_test.go:3710
[...]
2023-07-07T09:47:22.6078901Z   [odo] error starting container da1851b2f8e4d5a78ec3569ad8f4d627b96c694ba2d12366e5f1853558f05510: rootlessport listen tcp 127.0.0.1:24481: bind: address already in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jul 7, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [123.518 seconds]
E2E Test starting with non-empty Directory test debugging [It] should verify developer workflow from non-empty Directory
/go/odo_1/tests/e2escenarios/e2e_test.go:326

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [123.518 seconds]
E2E Test starting with non-empty Directory test debugging [It] should verify developer workflow from non-empty Directory
/go/odo_1/tests/e2escenarios/e2e_test.go:326

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ebe003e into redhat-developer:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serve the static files from odo dev
3 participants
@feloy @rm3l @openshift-merge-robot