Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid links in v3.11.0 blog post #6980

Merged

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jul 18, 2023

What type of PR is this:
/area documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6975.
Ideally, we should test that all links in our docs are valid, but this is the scope of #6617.

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

https://deploy-preview-6980--odo-docusaurus-preview.netlify.app/blog/odo-v3.11.0/

@rm3l rm3l requested a review from kadel July 18, 2023 15:30
@rm3l rm3l temporarily deployed to internal July 18, 2023 15:30 — with GitHub Actions Inactive
@netlify
Copy link

netlify bot commented Jul 18, 2023

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 7375d1c
😎 Deploy Preview https://odo-dev-pr-6980.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Jul 18, 2023
@openshift-ci openshift-ci bot requested a review from valaparthvi July 18, 2023 15:30
@rm3l rm3l removed the request for review from valaparthvi July 18, 2023 15:30
@rm3l rm3l closed this Jul 18, 2023
@rm3l rm3l reopened this Jul 18, 2023
@rm3l rm3l temporarily deployed to internal July 18, 2023 15:41 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Jul 18, 2023

Kubernetes Docs Tests on commit 8c9bcde finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 19, 2023
@rm3l
Copy link
Member Author

rm3l commented Jul 19, 2023

First deploy failed due to an internal error in Netlify:

Logs
5:30:41 PM: Failed during stage 'preparing repo': error checking for ref: pull/6980/head: : exit status 2
5:30:23 PM: build-image version: beb3f7b3d6069b85aae18cfa809c6c904c169629 (focal)
5:30:23 PM: buildbot version: 5124aec39b984d7b3af5d8cccde5d999304bb56e
5:30:23 PM: Fetching cached dependencies
5:30:23 PM: Starting to download cache of 912.1MB
5:30:32 PM: Finished downloading cache in 8.563s
5:30:32 PM: Starting to extract cache
5:30:40 PM: Finished extracting cache in 8.718s
5:30:40 PM: Finished fetching cache in 17.407s
5:30:40 PM: Starting to prepare the repo for build
5:30:41 PM: Failing build: Failed to prepare repo

But running it manually succeeded right after: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64b6b0660d9b2c00c1bcbf24
The check status was however not reflected on the PR..

The PR Preview GitHub Workflow also passed successfully: https://github.com/redhat-developer/odo/actions/runs/5589535058/jobs/10218031616?pr=6980

/override netlify/odo-docusaurus-preview/deploy-preview

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

@rm3l: Overrode contexts on behalf of rm3l: netlify/odo-docusaurus-preview/deploy-preview

In response to this:

First deploy failed due to an internal error in Netlify:

Logs
5:30:41 PM: Failed during stage 'preparing repo': error checking for ref: pull/6980/head: : exit status 2
5:30:23 PM: build-image version: beb3f7b3d6069b85aae18cfa809c6c904c169629 (focal)
5:30:23 PM: buildbot version: 5124aec39b984d7b3af5d8cccde5d999304bb56e
5:30:23 PM: Fetching cached dependencies
5:30:23 PM: Starting to download cache of 912.1MB
5:30:32 PM: Finished downloading cache in 8.563s
5:30:32 PM: Starting to extract cache
5:30:40 PM: Finished extracting cache in 8.718s
5:30:40 PM: Finished fetching cache in 17.407s
5:30:40 PM: Starting to prepare the repo for build
5:30:41 PM: Failing build: Failed to prepare repo

But running it manually succeeded right after: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64b6b0660d9b2c00c1bcbf24
The check status was however not reflected on the PR..

The PR Preview GitHub Workflow also passed successfully: https://github.com/redhat-developer/odo/actions/runs/5589535058/jobs/10218031616?pr=6980

/override netlify/odo-docusaurus-preview/deploy-preview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1624e4a into redhat-developer:main Jul 19, 2023
12 of 16 checks passed
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal July 19, 2023 14:55 — with GitHub Actions Inactive
@rm3l rm3l deleted the 6975-invalid-link-in-docs branch July 19, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid link in docs
3 participants