Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Bump github.com/onsi/ginkgo/v2 from 2.9.5 to 2.11.0 #6998

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 24, 2023

Bumps github.com/onsi/ginkgo/v2 from 2.9.5 to 2.11.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.11.0

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes

  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (#1218) [4a70a38]
  • Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#1219) [97eda4d]

v2.10.0

2.10.0

Features

  • feat(ginkgo/generators): add --tags flag (#1216) [a782a77] adds a new --tags flag to ginkgo generate

Fixes

  • Fix broken link of MIGRATING_TO_V2.md (#1217) [548d78e]

Maintenance

  • Bump golang.org/x/tools from 0.9.1 to 0.9.3 (#1215) [2b76a5e]

v2.9.7

2.9.7

Fixes

  • fix race when multiple defercleanups are called in goroutines [07fc3a0]

v2.9.6

2.9.6

Fixes

  • fix: create parent directory before report files (#1212) [0ac65de]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.6 to 1.27.7 (#1202) [3e39231]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes

  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (#1218) [4a70a38]
  • Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#1219) [97eda4d]

2.10.0

Features

  • feat(ginkgo/generators): add --tags flag (#1216) [a782a77] adds a new --tags flag to ginkgo generate

Fixes

  • Fix broken link of MIGRATING_TO_V2.md (#1217) [548d78e]

Maintenance

  • Bump golang.org/x/tools from 0.9.1 to 0.9.3 (#1215) [2b76a5e]

2.9.7

Fixes

  • fix race when multiple defercleanups are called in goroutines [07fc3a0]

2.9.6

Fixes

  • fix: create parent directory before report files (#1212) [0ac65de]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.6 to 1.27.7 (#1202) [3e39231]
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.9.5 to 2.11.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.9.5...v2.11.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. kind/task Issue is actionable task ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jul 24, 2023
@dependabot dependabot bot requested a review from a team July 24, 2023 02:37
@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit acf8aeb
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64bde3dbc9a3080008798df4

@openshift-ci openshift-ci bot requested review from feloy and rm3l July 24, 2023 02:37
@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Jul 24, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 24, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 24, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 24, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 24, 2023

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 24, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 24, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Jul 24, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

 [FAILED] [12.232 seconds]
odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
/go/odo_1/tests/integration/cmd_devfile_deploy_test.go:648

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

[FAILED] [12.232 seconds]
odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
/go/odo_1/tests/integration/cmd_devfile_deploy_test.go:648

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jul 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 24, 2023
@feloy
Copy link
Contributor

feloy commented Jul 24, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jul 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit 79f3685 into main Jul 24, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.11.0 branch July 24, 2023 07:50
@rm3l rm3l added this to the v3.13.0 🚀 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs kind/task Issue is actionable task lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants