Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display API logs #7008

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Do not display API logs #7008

merged 5 commits into from
Aug 1, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 31, 2023 •
edited
Loading

What type of PR is this:

  • updates and adapts the API Server code after the api spec change done in Serve SwaggerUI #6989.
  • mark go/routers.go and go/logger.go files to not regenerate them (because updated on our side)
  • It would nice to run make generate-api as part of the check-generated-files.yaml workflow, but a bug in the generator adding an unnecessary import "github.com/gorilla/mux" in go/api_default.go makes it not possible

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6987

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c0b0820
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64c8c4982e854900082c039b

@feloy feloy requested a review from rm3l July 31, 2023 09:15
@openshift-ci openshift-ci bot requested a review from kadel July 31, 2023 09:19
@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

NoCluster Tests on commit 7d26e45 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

Kubernetes Tests on commit 7d26e45 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 7d26e45 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6987/hide-http-logs branch from c41f79f to db8c792 Compare July 31, 2023 09:21
@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

Validate Tests on commit 7d26e45 finished successfully.
View logs: TXT HTML

@feloy feloy removed the request for review from kadel July 31, 2023 09:22
@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

Unit Tests on commit 7d26e45 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

OpenShift Tests on commit 7d26e45 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

Windows Tests (OCP) on commit 7d26e45 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6987/hide-http-logs branch from db8c792 to 1e047c2 Compare July 31, 2023 10:58
@odo-robot
Copy link

odo-robot bot commented Jul 31, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 8b29197 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 31, 2023
@feloy feloy changed the title [wip] Do not display API logs Do not display API logs Jul 31, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 31, 2023
rm3l
rm3l reviewed Aug 1, 2023
View reviewed changes
pkg/apiserver-impl/api_devstate_service.go Outdated Show resolved Hide resolved
pkg/apiserver-impl/api_devstate_service.go Outdated Show resolved Hide resolved
pkg/apiserver-gen/.openapi-generator-ignore Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy requested a review from rm3l August 1, 2023 08:54
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 49e38f5 into redhat-developer:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs from the API should not be displayed by default in the odo dev output
3 participants
@feloy @rm3l @openshift-merge-robot