-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use image selector feature in "Deploying application" guides #7013
Merged
openshift-merge-robot
merged 12 commits into
redhat-developer:main
from
rm3l:6976-deploying-an-application-should-use-image-selector-feature
Aug 2, 2023
Merged
Use image selector feature in "Deploying application" guides #7013
openshift-merge-robot
merged 12 commits into
redhat-developer:main
from
rm3l:6976-deploying-an-application-should-use-image-selector-feature
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to be able to use image selectors.
…might need to be updated To make things simple, use a public registry like ttl.sh that does not require authentication.
🔨 Deploy Preview deleted from internal cluster!
|
openshift-ci
bot
added
the
area/documentation
Issues or PRs related to documentation or the 'odo.dev' website
label
Aug 2, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
rm3l
changed the title
Use image selector feature in "Deploying an application" guides
Use image selector feature in "Deploying application" guides
Aug 2, 2023
feloy
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
openshift-ci
bot
added
the
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
label
Aug 2, 2023
openshift-merge-robot
temporarily deployed
to
internal
August 2, 2023 13:43 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Issues or PRs related to documentation or the 'odo.dev' website
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/area documentation
What does this PR do / why we need it:
This makes use of the image-name-as-selector feature in the "Deploy an application" guides. It also enhances other places in the same docs, like:
Which issue(s) this PR fixes:
Fixes #6976
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See all the guides under "Advanced Usage > Deploying application": https://odo-dev-pr-7013.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/docs/user-guides/advanced/deploy/