Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Fix Add/Remove events #7027

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[ui] Fix Add/Remove events #7027

merged 2 commits into from
Aug 21, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 7, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7022

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 7, 2023
@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c04e36c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64d11e59301bfb00080d81ac

@openshift-ci openshift-ci bot requested review from kadel and rm3l August 7, 2023 15:35
@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

NoCluster Tests on commit df37113 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit df37113 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

Unit Tests on commit df37113 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

Validate Tests on commit df37113 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

Kubernetes Tests on commit df37113 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

Windows Tests (OCP) on commit df37113 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

OpenShift Tests on commit df37113 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 7, 2023 •
edited
Loading

Kubernetes Docs Tests on commit e58ff71 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the fix-7022/ui-add-remove-events branch from 1cd8440 to c04e36c Compare August 7, 2023 16:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rm3l
rm3l approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 21, 2023
@rm3l rm3l added the area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder label Aug 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit fcc1cd8 into redhat-developer:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events selection
3 participants
@feloy @rm3l @openshift-merge-robot