Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Create/Delete volumes #7029

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 8, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7018

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 8, 2023
@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 9eb4e94
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64e37a0bdfcf72000847b430

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Aug 8, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l August 8, 2023 11:39
@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

OpenShift Unauthenticated Tests on commit 748addc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

NoCluster Tests on commit 748addc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

Unit Tests on commit 748addc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

Validate Tests on commit 748addc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

Kubernetes Tests on commit 748addc finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

Windows Tests (OCP) on commit 748addc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

OpenShift Tests on commit 748addc finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 8, 2023

Kubernetes Docs Tests on commit e58ff71 finished successfully.
View logs: TXT HTML

@feloy feloy closed this Aug 8, 2023
@feloy feloy reopened this Aug 8, 2023
@feloy feloy force-pushed the feature-7018/ui-volumes branch 2 times, most recently from f835a85 to 2088463 Compare August 9, 2023 13:16
@feloy feloy changed the title [wip] [ui] Create/Delete volumes [ui] Create/Delete volumes Aug 9, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 9, 2023
@rm3l rm3l added the area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder label Aug 21, 2023
@rm3l rm3l modified the milestone: v3.14.0 🚀 Aug 21, 2023
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 21, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor Author

feloy commented Aug 21, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

 [FAILED] [3.316 seconds]
odo create/delete/list/set namespace/project tests delete namespace when force-deleting a valid namespace [BeforeEach] should successfully delete the namespace asynchronously
  [BeforeEach] /go/odo_1/tests/integration/cmd_namespace_test.go:74
  [It] /go/odo_1/tests/integration/cmd_namespace_test.go:96

@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [3.316 seconds]
odo create/delete/list/set namespace/project tests delete namespace when force-deleting a valid namespace [BeforeEach] should successfully delete the namespace asynchronously
 [BeforeEach] /go/odo_1/tests/integration/cmd_namespace_test.go:74
 [It] /go/odo_1/tests/integration/cmd_namespace_test.go:96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Aug 21, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

[FAILED] [11.121 seconds]
odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
/go/odo_1/tests/integration/cmd_devfile_deploy_test.go:648

@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

[FAILED] [11.121 seconds]
odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
/go/odo_1/tests/integration/cmd_devfile_deploy_test.go:648

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit edf0bf3 into redhat-developer:main Aug 21, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Create Volume
3 participants