-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix potential namespace name collision issue with odo create/delete/list/set namespace/project
tests
#7050
Conversation
Otherwise, it might cause name collisions upon several subsequent runs of the same tests.
…ach test Do nothing if the namespace/project no longer exists
…each test Eventually check the existence of the created namespace/project.
This makes the intent clearer.
…testing project/namespace deletion
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Skipping CI for Draft Pull Request. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
odo create/delete/list/set namespace/project
testsodo create/delete/list/set namespace/project
tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix
What type of PR is this:
/area testing
What does this PR do / why we need it:
A random namespace/project was created in the
namespace is created with -w
tests, but never deleted, thus increasing the likelihood of name collisions upon several subsequent runs.This PR makes sure to delete such namespace/project and also makes other changes to be better resilient to similar issues in the future.
Which issue(s) this PR fixes:
Fixes #7044
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: