Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential namespace name collision issue with odo create/delete/list/set namespace/project tests #7050

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Aug 29, 2023

What type of PR is this:

/area testing

What does this PR do / why we need it:
A random namespace/project was created in the namespace is created with -w tests, but never deleted, thus increasing the likelihood of name collisions upon several subsequent runs.
This PR makes sure to delete such namespace/project and also makes other changes to be better resilient to similar issues in the future.

Which issue(s) this PR fixes:
Fixes #7044

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

rm3l added 5 commits August 29, 2023 11:35
Otherwise, it might cause name collisions
upon several subsequent runs of the same tests.
…ach test

Do nothing if the namespace/project no longer exists
…each test

Eventually check the existence of the created namespace/project.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 29, 2023
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 8402385
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64edc1d3774c270008a0d319

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Aug 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 29, 2023

Kubernetes Docs Tests on commit 64fd342 finished successfully.
View logs: TXT HTML

@rm3l rm3l changed the title [WIP] Fix potential namespace name collision issue with odo create/delete/list/set namespace/project tests Fix potential namespace name collision issue with odo create/delete/list/set namespace/project tests Aug 29, 2023
@rm3l rm3l marked this pull request as ready for review August 29, 2023 11:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 29, 2023
@openshift-ci openshift-ci bot requested review from feloy and kadel August 29, 2023 11:13
@rm3l rm3l removed the request for review from kadel August 29, 2023 11:13
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5895415 into redhat-developer:main Aug 29, 2023
@rm3l rm3l deleted the 7044-test-odo-create-delete-list-set-namespace-project-tests branch August 29, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
3 participants