Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Allow single item deletion from multi-value fields #7084

Merged
merged 14 commits into from
Sep 18, 2023
Merged

[UI] Allow single item deletion from multi-value fields #7084

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bdcf736
Support single endpoint deletion from multi-endpoints component
rm3l Sep 13, 2023
b3514e2
Support single command deletion from multi-commands component
rm3l Sep 13, 2023
4b7d0e3
Support single key-value item deletion from multi-key-value component
rm3l Sep 13, 2023
eaecfad
Support single text item deletion from multi-text component
rm3l Sep 13, 2023
b149eb0
Support single volume mount item deletion from multi-volume-mounts co…
rm3l Sep 13, 2023
a1ceb78
Add Cypress test cases
rm3l Sep 13, 2023
0a0ca54
Git-ignore Cypress screenshots folder
rm3l Sep 13, 2023
b43be6d
Generate static UI
rm3l Sep 13, 2023
d588446
Update Delete icon and add tooltip to it
rm3l Sep 15, 2023
4bf895f
Move the "delete endpoint" button closer to the element it is attache…
rm3l Sep 15, 2023
8f70f87
Generate static UI
rm3l Sep 15, 2023
e6d0d0b
Revert "Move the "delete endpoint" button closer to the element it is…
rm3l Sep 15, 2023
3001acb
Move the "delete endpoint" buttons closer to the elements they are at…
rm3l Sep 15, 2023
b0412b0
Generate static UI
rm3l Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/app/controls/multi-key-value/multi-key-value.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
div.group { margin-bottom: 16px; }
.mid-width { width: 50%; }
.kv-width { width: 45%; }
12 changes: 6 additions & 6 deletions ui/src/app/controls/multi-key-value/multi-key-value.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<div class="group">
<div *ngFor="let control of form.controls; index as i">
<ng-container [formGroup]="control">
<mat-form-field class="mid-width" appearance="outline">
<mat-form-field class="kv-width" appearance="outline">
<mat-label><span>Name</span></mat-label>
<input [attr.data-cy]="dataCyPrefix+'-name-'+i" matInput formControlName="name">
</mat-form-field>
<mat-form-field class="mid-width" appearance="outline">
<mat-form-field class="kv-width" appearance="outline">
<mat-label><span>Value</span></mat-label>
<input [attr.data-cy]="dataCyPrefix+'-value-'+i" matInput formControlName="value">
</mat-form-field>
<button [attr.data-cy]="dataCyPrefix+'-minus-'+i" mat-icon-button (click)="removeEntry(i)">
<mat-icon class="tab-icon material-icons-outlined">remove</mat-icon>
feloy marked this conversation as resolved.
Show resolved Hide resolved
</button>
</ng-container>
</div>
<button [attr.data-cy]="dataCyPrefix+'-plus'" *ngIf="form.controls.length > 0" mat-icon-button (click)="addEntry('', '')">
<mat-icon class="tab-icon material-icons-outlined">add</mat-icon>
</button>
<button [attr.data-cy]="dataCyPrefix+'-add'" *ngIf="form.controls.length == 0" mat-flat-button (click)="addEntry('', '')">{{addLabel}}</button>
<button [attr.data-cy]="dataCyPrefix+'-add'" mat-flat-button (click)="addEntry('', '')">{{addLabel}}</button>
</div>
4 changes: 4 additions & 0 deletions ui/src/app/controls/multi-key-value/multi-key-value.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ export class MultiKeyValueComponent implements ControlValueAccessor, Validator {
this.form.push(this.newKeyValueForm({name, value}));
}

removeEntry(index: number) {
this.form.removeAt(index);
}

/* Validator implementation */
validate(control: AbstractControl): ValidationErrors | null {
if (!this.form.valid) {
Expand Down