Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize devfile.yml and .devfile.yml as Devfiles #7130

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Recognize devfile.yml and .devfile.yml as Devfiles #7130

merged 6 commits into from
Dec 1, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Oct 24, 2023 •
edited
Loading

What type of PR is this:

/kind bug

What does this PR do / why we need it:
This allows us to test and validate the work done on devfile/api#1265

Which issue(s) this PR fixes:
Fixes #7060

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Repro steps in #7060

@rm3l rm3l added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Oct 24, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 3048a4c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6569a9b2bfa3fb0008727c24

@rm3l rm3l force-pushed the 1265-support-.yml-extension--devfile-library branch from ff224cf to 5b4c255 Compare October 24, 2023 08:29
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Oct 24, 2023
@odo-robot
Copy link

odo-robot bot commented Oct 24, 2023 •
edited
Loading

Windows Tests (OCP) on commit c840252 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 24, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit c840252 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 24, 2023 •
edited
Loading

NoCluster Tests on commit c840252 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 24, 2023 •
edited
Loading

Unit Tests on commit c840252 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 24, 2023 •
edited
Loading

Validate Tests on commit c840252 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 24, 2023 •
edited
Loading

Kubernetes Tests on commit c840252 finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the 1265-support-.yml-extension--devfile-library branch from 5b4c255 to fadc5f9 Compare October 24, 2023 08:58
@odo-robot
Copy link

odo-robot bot commented Oct 24, 2023 •
edited
Loading

OpenShift Tests on commit c840252 finished successfully.
View logs: TXT HTML

@rm3l rm3l mentioned this pull request Oct 24, 2023
Merged
5 tasks
@rm3l rm3l force-pushed the 1265-support-.yml-extension--devfile-library branch 3 times, most recently from 43d61a0 to bc1bd98 Compare November 2, 2023 08:17
@rm3l rm3l closed this Nov 2, 2023
@rm3l rm3l reopened this Nov 2, 2023
@rm3l rm3l closed this Nov 2, 2023
@rm3l rm3l reopened this Nov 2, 2023
@rm3l rm3l mentioned this pull request Nov 2, 2023
Closed
@rm3l rm3l changed the title [WIP] Update devfile library to test changes in parser bahavior Recognize devfile.yml and .devfile.yml as Devfiles Nov 2, 2023
@rm3l rm3l marked this pull request as ready for review November 2, 2023 18:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 2, 2023
@openshift-ci openshift-ci bot requested a review from kadel November 2, 2023 18:16
@rm3l rm3l added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow. labels Nov 2, 2023
@rm3l rm3l mentioned this pull request Nov 2, 2023
Closed
@rm3l rm3l closed this Nov 2, 2023
@rm3l rm3l reopened this Nov 2, 2023
@rm3l rm3l added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Nov 28, 2023
@rm3l rm3l force-pushed the 1265-support-.yml-extension--devfile-library branch from bd19d1f to 3048a4c Compare December 1, 2023 09:38
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 1, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 1, 2023

New changes are detected. LGTM label has been removed.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Dec 1, 2023
@odo-robot odo-robot
Copy link

odo-robot bot commented Dec 1, 2023

Kubernetes Docs Tests on commit 15f663f finished successfully.
View logs: TXT HTML

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 1, 2023
@rm3l rm3l merged commit 0f2103e into redhat-developer:main Dec 1, 2023
16 checks passed
@rm3l rm3l deleted the 1265-support-.yml-extension--devfile-library branch December 1, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel Awaiting requested review from kadel

Assignees
No one assigned
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recognise devfile.yml and .devfile.yml as Devfiles
2 participants
@rm3l @openshift-merge-robot