Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start HTTP server to replace Devfile Registry server in the tests #7154

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Start HTTP server to replace Devfile Registry server in the tests #7154

merged 4 commits into from
Dec 1, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Nov 28, 2023 •
edited
Loading

What type of PR is this:
/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Nov 28, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 5250cdf
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6569989196c3000007d8598a

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

Windows Tests (OCP) on commit d9eb25e finished successfully.
View logs: TXT HTML

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 5250cdf
😎 Deploy Preview https://odo-dev-pr-7154.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit d9eb25e finished successfully.
View logs: TXT HTML

@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

NoCluster Tests on commit d9eb25e finished successfully.
View logs: TXT HTML

@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

Unit Tests on commit d9eb25e finished successfully.
View logs: TXT HTML

@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

Validate Tests on commit d9eb25e finished successfully.
View logs: TXT HTML

@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

Kubernetes Tests on commit d9eb25e finished successfully.
View logs: TXT HTML

@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

OpenShift Tests on commit d9eb25e finished successfully.
View logs: TXT HTML

@rm3l rm3l closed this Nov 28, 2023
@rm3l rm3l reopened this Nov 28, 2023
@odo-robot odo-robot
Copy link

odo-robot bot commented Nov 28, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 172c57d finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from 9befe4d to 6215c6e Compare November 29, 2023 08:59
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from 6215c6e to 3d15833 Compare November 29, 2023 09:24
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from 3d15833 to e62bfc9 Compare November 29, 2023 12:58
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from e62bfc9 to 0335059 Compare November 30, 2023 00:31
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from 0335059 to 25cd60d Compare November 30, 2023 08:52
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from 25cd60d to 790b776 Compare November 30, 2023 08:57
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from efcf9db to fa023d7 Compare November 30, 2023 21:03
rm3l added 3 commits November 30, 2023 22:41
@rm3l
Make tests start an HTTP server service Devfile artifacts
6285c32 
This allows us to remove the dependency on a Devfile Registry server.
We no longer want to have a long-running cluster
to which a Devfile registry is deployed.
And relying on the public staging registry
makes those tests sometimes fail, due
to the frequency of updates and changes that break
our tests.
Now, an HTTP Server instance is started
on a random ports and serves the OCI artifacts for
the stacks that are useful for our tests.

Note that this will now be the default behavior,
unless the DEVFILE_REGISTRY env var is explicitly set.

This allows us to also update the stacks at our own pace.
The process for updating is as follows:
1- update the stacks folder under tests/helper/registry_server/testdata/registry
2- run 'generate-test-registry-build' to regenerate the Devfile Index
and OCI archives for stack extra-files
3- Commit and push the changes
@rm3l
Fix integration tests with the updates stacks
c435c93
@rm3l
Fix doc-automation tests
63e6740 
The registry URL is now  by default.
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from fa023d7 to d52a037 Compare November 30, 2023 22:00
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from d52a037 to fa59a84 Compare November 30, 2023 22:43
@rm3l rm3l changed the title [WIP] Start HTTP server to replace Devfile Registry server in the tests Start HTTP server to replace Devfile Registry server in the tests Dec 1, 2023
@rm3l rm3l closed this Dec 1, 2023
@rm3l rm3l reopened this Dec 1, 2023
@rm3l
Fix Windows tests script
5250cdf 
For some reason, "scp" was not able to find the destination folder.
@rm3l rm3l force-pushed the 6138-integration-tests-fail-after-change-in-devfile-registry branch from fa59a84 to 5250cdf Compare December 1, 2023 08:25
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l marked this pull request as ready for review December 1, 2023 09:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 1, 2023
@rm3l rm3l self-assigned this Dec 1, 2023
@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 1, 2023
@openshift-ci openshift-ci bot requested a review from kadel December 1, 2023 09:09
@rm3l rm3l removed the request for review from kadel December 1, 2023 09:09
@rm3l rm3l merged commit 15f663f into redhat-developer:main Dec 1, 2023
12 checks passed
@rm3l rm3l deleted the 6138-integration-tests-fail-after-change-in-devfile-registry branch December 1, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rm3l rm3l

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc automation tests not passing Integration tests fail after change in devfile registry
1 participant
@rm3l