This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Enable PVC pre-create subpaths property by default. #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an issue with how Kubernetes creates paths in PVCs, enabling the precreate option is required. Otherwise, the cleanup job on workspace deletion fails to remove directories (files are removed correctly) Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk The che server [build 1130] failed.If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel. |
ibuziuk
approved these changes
Feb 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable
CHE_INFRA_KUBERNETES_PVC_PRECREATE__SUBPATHSby default.What issues does this PR fix or reference?
See #1195 and eclipse-che/che#12445 (comment)
How have you tested this PR?
Tried to test on dev-cluster/2a, but ran into
Failed to start Kubernetes runtime of workspace workspacepq096rpun47m7x48. Cause: Server 'theia' in machine 'ws/theia-ide' not available.. However, workspace pods are created successfully (pre-creation happens before that) and workspace is deleted without issue.Housekeeping PRs
https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/2541 for enabling on staging only