Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use PVC for dynamic-plugins-root #40

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

kadel
Copy link
Member

@kadel kadel commented Aug 12, 2024

Description of the change

Updates default values to have regular PVC for dynamic-plugins-root instead of previously used ephemeral storage.

This will allow us to add logic to install-dynamic-plugins.py script to download plugins only when needed.

Existing or Associated Issue(s)

https://issues.redhat.com/browse/RHIDP-3569

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

gazarenkov

This comment was marked as off-topic.

@gazarenkov gazarenkov self-requested a review August 20, 2024 18:31
Copy link
Member

@gazarenkov gazarenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both ClusterBot and Dev Sandbox. Also tested upgrading an existing 1.2 Helm release to the chart in this branch. No particular issue.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2024
@rm3l rm3l merged commit 507daf6 into redhat-developer:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants