enable semantic highlighting by default

README.md

@@ -157,7 +157,7 @@ The following settings are supported:
   Default launch mode is `Hybrid`. Legacy mode is `Standard`
 * `java.sources.organizeImports.starThreshold`: Specifies the number of imports added before a star-import declaration is used, default is 99.
 * `java.sources.organizeImports.staticStarThreshold`: Specifies the number of static imports added before a star-import declaration is used, default is 99.
-* `java.semanticHighlighting.enabled`: Enable/disable [Semantic Highlighting](https://github.com/redhat-developer/vscode-java/wiki/Semantic-Highlighting) for Java files. Defaults to `false`.
+* `java.semanticHighlighting.enabled`: Enable/disable [Semantic Highlighting](https://github.com/redhat-developer/vscode-java/wiki/Semantic-Highlighting) for Java files. Defaults to `true`.
 * `java.requirements.JDK11Warning`: Enable/disable a warning about the impending requirement of Java 11. Defaults to `true`.
 * `java.refactor.renameFromFileExplorer`: Specifies whether to update imports and package declarations when renaming files from File Explorer. Defaults to `prompt`.
   - `never`: Don't enable refactoring for rename operations on File Explorer.
@@ -175,10 +175,6 @@ Semantic Highlighting
 ===============
 [Semantic Highlighting](https://github.com/redhat-developer/vscode-java/wiki/Semantic-Highlighting) is controlled by the `java.semanticHighlighting.enabled` preference. When enabled, it fixes numerous syntax highlighting issues with the default Java Textmate grammar. However, you might experience different small issues, particularly a delay when it kicks in, as it needs to be computed by the Java Language server, when opening a new file or when typing.
 
-You will be prompted to enable or disable it on startup:
-
-![](https://user-images.githubusercontent.com/148698/80595049-65d2f000-8a24-11ea-8d9c-19b05b9cac15.png)
-
 Troubleshooting
 ===============
 1. Check the status of the language tools on the lower right corner (marked with A on image below).

package.json

@@ -547,7 +547,7 @@
         },
         "java.semanticHighlighting.enabled": {
           "type": "boolean",
-          "default": false,
+          "default": true,
           "description": "Enable/disable the semantic highlighting.",
           "scope": "window"
         },

src/semanticTokenProvider.ts

@@ -1,24 +1,14 @@
 import * as vscode from 'vscode';
 import { Commands } from './commands';
-import { getJavaConfiguration, isPreferenceOverridden } from './utils';
+import { getJavaConfiguration } from './utils';
 
 const semanticHighlightingKey = 'java.semanticHighlighting.enabled';
 
 export function registerSemanticTokensProvider(context: vscode.ExtensionContext) {
     if (!vscode.languages.registerDocumentSemanticTokensProvider) { // in case Theia doesn't support this API
         return;
     }
-    if (!isPreferenceOverridden(semanticHighlightingKey)) {
-        const enable = "Enable";
-        const disable = "Disable";
-        vscode.window.showInformationMessage("Enable [Semantic highlighting](https://github.com/redhat-developer/vscode-java/wiki/Semantic-Highlighting) for Java by default?", enable, disable).then(selection => {
-            if (selection === enable) {
-                vscode.workspace.getConfiguration().update(semanticHighlightingKey, true, vscode.ConfigurationTarget.Global);
-            } else if (selection === disable) {
-                vscode.workspace.getConfiguration().update(semanticHighlightingKey, false, vscode.ConfigurationTarget.Global);
-            }
-        });
-    }
+
     if (isSemanticHighlightingEnabled()) {
         getSemanticTokensLegend().then(legend => {
             const documentSelector = [