Do not call getAllComponents() in activate

Part of #3850 Signed-off-by: David Thompson <davthomp@redhat.com>
redhat-developer · Feb 6, 2024 · 9ae98bd · 9ae98bd
1 parent eb06f1c
commit 9ae98bd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/extension.ts b/src/extension.ts
@@ -204,7 +204,6 @@ export async function activate(extensionContext: ExtensionContext): Promise<unkn
     updateStatusBarItem(crcStatusItem, 'Stop CRC');
     void extendClusterExplorer();
 
-    await ComponentTypesView.instance.getAllComponents();
     await registerKubernetesCloudProvider();
     void startTelemetry(extensionContext);
     await verifyBinariesInRemoteContainer();

diff --git a/src/webview/create-component/createComponentLoader.ts b/src/webview/create-component/createComponentLoader.ts
@@ -18,6 +18,8 @@ import { ComponentTypesView } from '../../registriesView';
 import sendTelemetry from '../../telemetry';
 import { ExtensionID } from '../../util/constants';
 import { DevfileConverter } from '../../util/devfileConverter';
+import { DevfileV1 } from '../../util/devfileV1Type';
+import { Progress } from '../../util/progress';
 import { getInitialWorkspaceFolder, selectWorkspaceFolder } from '../../util/workspace';
 import {
     getDevfileCapabilities,
@@ -29,7 +31,6 @@ import {
 } from '../common-ext/createComponentHelpers';
 import { loadWebviewHtml, validateGitURL } from '../common-ext/utils';
 import { Devfile, DevfileRegistry, TemplateProjectIdentifier } from '../common/devfile';
-import { DevfileV1 } from '../../util/devfileV1Type';
 
 interface CloneProcess {
     status: boolean;
@@ -53,6 +54,9 @@ export default class CreateComponentLoader {
     }
 
     static async loadView(title: string, folderPath?: string): Promise<WebviewPanel> {
+        if (ComponentTypesView.instance.getCompDescriptions().size === 0) {
+            await Progress.execFunctionWithProgress('Loading available component types...', () => ComponentTypesView.instance.getAllComponents())
+        }
         if (CreateComponentLoader.panel) {
             CreateComponentLoader.panel.reveal();
             return;

diff --git a/src/webview/devfile-registry/registryViewLoader.ts b/src/webview/devfile-registry/registryViewLoader.ts
@@ -10,6 +10,7 @@ import { Odo } from '../../odo/odoWrapper';
 import { ComponentTypesView } from '../../registriesView';
 import sendTelemetry from '../../telemetry';
 import { ExtensionID } from '../../util/constants';
+import { Progress } from '../../util/progress';
 import { getInitialWorkspaceFolder, selectWorkspaceFolder } from '../../util/workspace';
 import { vsCommand } from '../../vscommand';
 import { getDevfileCapabilities, getDevfileRegistries, getDevfileTags, isValidProjectFolder, validateName, validatePortNumber } from '../common-ext/createComponentHelpers';
@@ -155,6 +156,9 @@ export default class RegistryViewLoader {
     }
 
     static async loadView(title: string, url?: string): Promise<vscode.WebviewPanel> {
+        if (ComponentTypesView.instance.getCompDescriptions().size === 0) {
+            await Progress.execFunctionWithProgress('Loading available component types...', () => ComponentTypesView.instance.getAllComponents())
+        }
         const localResourceRoot = vscode.Uri.file(path.join(RegistryViewLoader.extensionPath, 'out', 'devfileRegistryViewer'));
         if (panel) {
             if (RegistryViewLoader.url !== url) {