Fix code scanning issue "incomplete URL substring"

Fixes #2896, Fixes #2895 Signed-off-by: David Thompson <davthomp@redhat.com>
redhat-developer · May 24, 2023 · df29b33 · df29b33
1 parent 928fb61
commit df29b33
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/webview/devfile-registry/app/home.tsx b/src/webview/devfile-registry/app/home.tsx
@@ -60,12 +60,13 @@ export const Home: React.FC<DefaultProps> = ({ }) => {
                 } else {
                     setError('');
                     if (message.data.registries.length === 1) {
-                        message.data.registries.map((registry: Registry) => {
+                        message.data.registries.forEach((registry: Registry) => {
                             registry.state = true;
                         });
                     } else {
-                        message.data.registries.map((registry: Registry) => {
-                            if (registry.url.toLowerCase().indexOf('https://registry.devfile.io') !== -1) {
+                        message.data.registries.forEach((registry: Registry) => {
+                            const devfileUrl = new URL(registry.url);
+                            if (devfileUrl.hostname.toLowerCase() === 'registry.devfile.io') {
                                 registry.state = true;
                             }
                         });
@@ -111,8 +112,9 @@ export const Home: React.FC<DefaultProps> = ({ }) => {
                                     });
                                     const allUncheckedRegistries = filteredRegistries.filter((registry: Registry) => !registry.state);
                                     if (allUncheckedRegistries.length === registries.length) {
-                                        allUncheckedRegistries.map((uncheckedRegistry: Registry) => {
-                                            if (uncheckedRegistry.url.toLowerCase().indexOf('https://registry.devfile.io') !== -1) {
+                                        allUncheckedRegistries.forEach((uncheckedRegistry: Registry) => {
+                                            const registryUrl = new URL(uncheckedRegistry.url);
+                                            if (registryUrl.hostname.toLowerCase() === 'registry.devfile.io') {
                                                 uncheckedRegistry.state = true;
                                             }
                                         })