Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Components View' to show components in current workspace #2008

Closed
dgolovin opened this issue Mar 6, 2021 · 0 comments · Fixed by #2012
Closed

'Components View' to show components in current workspace #2008

dgolovin opened this issue Mar 6, 2021 · 0 comments · Fixed by #2012
Assignees
@dgolovin
Labels
demo Show in sprint review demo kind/feature priority/major
Milestone
v0.2.4

Comments

@dgolovin
Copy link
Collaborator

dgolovin commented Mar 6, 2021

Currently Applications Explorer View shows only components form current context, but in case there are components in workspace form different project or project from another clusters they are not visible in Application Explorer View. Components view should show all the worksapce folders that contains odo component and let browse and open source files without switching to Explorer view.
@dgolovin dgolovin added this to the v0.2.4 milestone Mar 9, 2021
@dgolovin dgolovin mentioned this issue Mar 9, 2021
Merged
@dgolovin dgolovin self-assigned this Mar 10, 2021
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue Mar 11, 2021
@dgolovin
Components View first iteration
2a16469 
This PR fixes redhat-developer#2008.

This fix adds:
1. Components View (View)  under Application Explorer
2. View shows components discovered in workspace root folders
3. Detection for devfile components based on odo env view, which works
   when cluster is not accessible or user is logged off from cluster
4. Detection for s2i components based on parsing .odo/config.yaml
   (forkaround for odo env view not working for s2i components)
5. Refresh for View based after event about new folder added to
   workspace
6. Refrehs for View after component created form existing workspace
   folder (to avoid using watch for every folder in workspace)
7. Reveal in Explorer for components to activate Explorer view and
   select context folder (not always working correctly first time, have
   no idea why)

Not implemented yet:
1. Show folders/files under component node (requires some work to
   incorporate filesystem watching with exlusion for folders like
   'node_modules'
2. Watching for filesystem changes or focus ganed event to detect
   changes done in vscode terminal or external terminal
3. Showing hierarchy Project/Application/Component rather than flat list
4. Support pushing components to cluster from the view, especially for
   components with project that does not exist or currently not active
5. Showing state Pushed/Not pushed for components pushed to current
   cluster/namespace (or current context)
6. No icons yet
7. No view Welcome page with 'Create Component' button
8. No support to create component when there is no accessible cluster or
   user is logged off (there should be quick input requests for project
   and application names, there should be qiuickpiks provided that allow
   to select existing and not existing projects/applications)

Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin added a commit that referenced this issue Mar 12, 2021
@dgolovin
Components View first iteration (#2012)
5ed1e8c 
* Components View first iteration

This PR fixes #2008.

This fix adds:
1. Components View (View)  under Application Explorer
2. View shows components discovered in workspace root folders
3. Detection for devfile components based on odo env view, which works
   when cluster is not accessible or user is logged off from cluster
4. Detection for s2i components based on parsing .odo/config.yaml
   (forkaround for odo env view not working for s2i components)
5. Refresh for View based after event about new folder added to
   workspace
6. Refrehs for View after component created form existing workspace
   folder (to avoid using watch for every folder in workspace)
7. Reveal in Explorer for components to activate Explorer view and
   select context folder (not always working correctly first time, have
   no idea why)
8. Support to create component when there is no accessible cluster or
   user is logged off (there should be quick input requests for project
   and application names, there should be qiuickpiks provided that allow
   to select existing and not existing projects/applications)

Not implemented yet:
1. Show folders/files under component node (requires some work to
   incorporate filesystem watching with exlusion for folders like
   'node_modules'
2. Watching for filesystem changes or focus ganed event to detect
   changes done in vscode terminal or external terminal
3. Showing hierarchy Project/Application/Component rather than flat list
4. Support pushing components to cluster from the view, especially for
   components with project that does not exist or currently not active
5. Showing state Pushed/Not pushed for components pushed to current
   cluster/namespace (or current context)
6. No icons yet
7. No view Welcome page with 'Create Component' button


Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin added the demo Show in sprint review demo label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
demo Show in sprint review demo kind/feature priority/major
Projects
None yet
Milestone
v0.2.4
Development

Successfully merging a pull request may close this issue.

Components View first iteration dgolovin/vscode-openshift-tools
1 participant
@dgolovin