Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request if components should be deleted when deleting Application or Project from Application explorer #2023

Closed
dgolovin opened this issue Mar 11, 2021 · 1 comment · Fixed by #3022
Assignees
Labels
Milestone

Comments

@dgolovin
Copy link
Collaborator

As @jrichter1 again pointed out current deletion command behavior for Project or Application is inconsistent. There should be common approach when deleting resources with multiple nested resources in it. There should be confirmation from user requested if all the components within project or application should be deleted as well.

@dgolovin dgolovin added kind/enhancement New feature or request priority/major labels Mar 11, 2021
@dgolovin dgolovin added this to the v0.2.5 milestone Mar 11, 2021
@dgolovin dgolovin self-assigned this Mar 11, 2021
@dgolovin dgolovin modified the milestones: v0.2.5, v0.2.6, v0.2.7 May 4, 2021
@dgolovin dgolovin modified the milestones: v0.2.10, v0.2.11 Aug 18, 2021
@mohitsuman mohitsuman modified the milestones: v0.3.3, v0.3.2 Sep 14, 2021
@mohitsuman mohitsuman modified the milestones: v0.3.2, v0.3.1 Feb 23, 2022
@mohitsuman mohitsuman modified the milestones: 0.4.0, 0.5.0, 0.6.0 Apr 5, 2022
@mohitsuman mohitsuman modified the milestones: 0.5.0, 0.6.0 Apr 26, 2022
@mohitsuman mohitsuman modified the milestones: 0.6.0, Backlog May 18, 2022
@mohitsuman mohitsuman modified the milestones: Backlog, 1.6.0 Jul 1, 2023
@mohitsuman mohitsuman assigned datho7561 and unassigned dgolovin Jul 1, 2023
@datho7561
Copy link
Contributor

This workflow has changed a bit since this bug was filed (we don't display applications in the application explorer). Is the general idea to update the wording on the prompt to delete a project to include "and all resources in the project"? There isn't a way to delete the project without deleting the resources it contains. Also, there is no obvious way to detect which local components should be deleted when deleting a project, since devfiles don't tie components to a particular project.

datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Jul 13, 2023
- Add some integration tests for the `oc` commands we call in the file

Closes redhat-developer#2023

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Jul 13, 2023
- Add some integration tests for the `oc` commands we call in the file

Closes redhat-developer#2023

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit that referenced this issue Jul 14, 2023
- Add some integration tests for the `oc` commands we call in the file

Closes #2023

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants