Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Welcome page in the same pane of the editor #2121

Closed
mohitsuman opened this issue May 6, 2021 · 0 comments · Fixed by #2134
Closed

Open Welcome page in the same pane of the editor #2121

mohitsuman opened this issue May 6, 2021 · 0 comments · Fixed by #2134
Assignees
@dgolovin
Labels
kind/bug priority/critical
Milestone
v0.2.6

Comments

@mohitsuman
Copy link
Collaborator

Current Scenario

  • Once the extension is activated, OpenShift Connector Welcome Page is loaded. If the editor already has a tab opened, the Welcome page tries to open in a new pane, which basically splits the view.

Screenshot 2021-05-07 at 12 54 19 AM

Expected Behaviour

  • The Welcome page should open in the same pane of the editor.
@mohitsuman mohitsuman modified the milestones: v0.2.5, v0.2.6 May 6, 2021
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue May 11, 2021
@dgolovin
Update vscode-welcome-view to 0.0.4 to open view in active column
8d74166 
This PR fixes redhat-developer#2121.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin mentioned this issue May 11, 2021
Merged
dgolovin added a commit that referenced this issue May 11, 2021
@dgolovin
Update vscode-welcome-view to 0.0.4 to open view in active column
12128ee 
This PR fixes #2121.

Signed-off-by: Denis Golovin dgolovin@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
kind/bug priority/critical
Projects
None yet
Milestone
v0.2.6
Development

Successfully merging a pull request may close this issue.

Update vscode-welcome-view to 0.0.4 to open view in active column dgolovin/vscode-openshift-tools
2 participants
@dgolovin @mohitsuman