Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome View: OpenShift: Welcome command does not open Welcome View if 'Show Welcome Page' preference is not set #2510

Closed
dgolovin opened this issue Aug 17, 2022 · 0 comments · Fixed by #2513
Closed

Welcome View: OpenShift: Welcome command does not open Welcome View if 'Show Welcome Page' preference is not set #2510

dgolovin opened this issue Aug 17, 2022 · 0 comments · Fixed by #2513
Assignees
@dgolovin
Labels
kind/bug priority/major
Milestone
0.6.0

Comments

@dgolovin
Copy link
Collaborator

dgolovin commented Aug 17, 2022 •
edited
Loading

OpenShift connector welcome screen by default is opened when extension is activated. If ones unselect 'Show welcome page when OpenShift Connector Extension is activated' in the bottom of Welcome page it is not going to be activated at next start which is expected. It should not affect OpenShift: Weclome command but it does and command stops opening Welcome page as well.
@dgolovin dgolovin self-assigned this Aug 17, 2022
@dgolovin dgolovin added this to the 0.6.0 milestone Aug 17, 2022
@dgolovin dgolovin mentioned this issue Aug 19, 2022
Merged
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue Aug 19, 2022
@dgolovin
OpenShift: Weclome command should always open Welcome page
b91d58b 
This PR fixes redhat-developer#2510.

Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin added a commit that referenced this issue Aug 19, 2022
@dgolovin
OpenShift: Weclome command should always open Welcome page
66232c4 
This PR fixes #2510.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin changed the title Welcome View: OpenShift: Welcome command does not open Welcome View if 'Show Welcome Page' prefernce is not set Welcome View: OpenShift: Welcome command does not open Welcome View if 'Show Welcome Page' preference is not set Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
kind/bug priority/major
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

OpenShift: Weclome command should always open Welcome page dgolovin/vscode-openshift-tools
1 participant
@dgolovin