Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm install warnings for packages and their dependencies #2658

Closed
odockal opened this issue Nov 8, 2022 · 2 comments · Fixed by #2748
Closed

Fix npm install warnings for packages and their dependencies #2658

odockal opened this issue Nov 8, 2022 · 2 comments · Fixed by #2748
Assignees
Labels
component/build dependencies Pull requests that update a dependency file kind/task
Milestone

Comments

@odockal
Copy link
Contributor

odockal commented Nov 8, 2022

When running npm install, there is a lot of conflicting deps and vulnerability warnings.

$ npm i
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-dom@16.14.0
npm WARN Found: react@17.0.2
npm WARN node_modules/react
npm WARN   dev react@"^17.0.2" from the root project
npm WARN   39 more (@emotion/react, @emotion/styled, @material-ui/core, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.14.0" from react-dom@16.14.0
npm WARN node_modules/react-lazylog/node_modules/react-dom
npm WARN   peer react-dom@"^15.3.0 || ^16.0.0-alpha" from react-virtualized@9.22.3
npm WARN   node_modules/react-lazylog/node_modules/react-virtualized
npm WARN 
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@"^16.14.0" from react-dom@16.14.0
npm WARN   node_modules/react-lazylog/node_modules/react-dom
npm WARN     peer react-dom@"^15.3.0 || ^16.0.0-alpha" from react-virtualized@9.22.3
npm WARN     node_modules/react-lazylog/node_modules/react-virtualized
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-virtualized@9.22.3
npm WARN Found: react@17.0.2
npm WARN node_modules/react
npm WARN   dev react@"^17.0.2" from the root project
npm WARN   39 more (@emotion/react, @emotion/styled, @material-ui/core, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^15.3.0 || ^16.0.0-alpha" from react-virtualized@9.22.3
npm WARN node_modules/react-lazylog/node_modules/react-virtualized
npm WARN   react-virtualized@"^9.21.0" from react-lazylog@4.5.3
npm WARN   node_modules/react-lazylog
npm WARN 
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@"^15.3.0 || ^16.0.0-alpha" from react-virtualized@9.22.3
npm WARN   node_modules/react-lazylog/node_modules/react-virtualized
npm WARN     react-virtualized@"^9.21.0" from react-lazylog@4.5.3
npm WARN     node_modules/react-lazylog

added 22 packages, removed 2 packages, changed 43 packages, and audited 1769 packages in 6s

290 packages are looking for funding
  run `npm fund` for details

6 vulnerabilities (5 moderate, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
@odockal odockal added kind/task component/build dependencies Pull requests that update a dependency file labels Nov 8, 2022
@mohitsuman
Copy link
Collaborator

It depends on the node version while doing npm install.
@odockal

  • What is the node version?
  • What is the platform?

@dgolovin
Copy link
Collaborator

This is hard one, some react-lazylog module is not maintained anymore and therefore stack on specific react version.

@mohitsuman mohitsuman added this to the 1.1.0 milestone Dec 13, 2022
@mohitsuman mohitsuman moved this to 🆕 New in Adapters Sprint Dec 14, 2022
@mohitsuman mohitsuman moved this from 🆕 New to 🔖 Ready in Adapters Sprint Dec 14, 2022
@mohitsuman mohitsuman modified the milestones: 1.1.0, 1.2.0 Dec 14, 2022
@msivasubramaniaan msivasubramaniaan moved this from 🔖 Ready to 🏗 In progress in Adapters Sprint Jan 24, 2023
@msivasubramaniaan msivasubramaniaan moved this from 🏗 In progress to 👀 In review in Adapters Sprint Jan 24, 2023
@msivasubramaniaan msivasubramaniaan moved this to 👀 In review in IDE Cloudaptors Jan 30, 2023
@mohitsuman mohitsuman modified the milestones: 1.2.0, 1.3.0 Feb 2, 2023
rgrunber pushed a commit that referenced this issue Mar 3, 2023
* Fixes #2658 
* done npm audit and bump npm-check-updates

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Mar 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Adapters Sprint Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build dependencies Pull requests that update a dependency file kind/task
Projects
Status: Done
Archived in project
4 participants