Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstalling Helm releases only works when the name of the release ends with the name of the chart #3021

Closed
datho7561 opened this issue Jul 13, 2023 · 0 comments · Fixed by #3071
Assignees
Labels
Milestone

Comments

@datho7561
Copy link
Contributor

Let's say you create a Helm release called my-janus, based on the backstage Helm chart from the OpenShift Helm repository:

helm-release-uninstall-pt1

It will appear in the "Application Explorer" panel as my-janus-backstage:

helm-release-uninstall-pt2

If you attempt to use the context menu to uninstall the Helm release:

helm-release-uninstall-pt3

Then nothing happens.

This is because the command is trying to uninstall the release my-janus-backstage, but the release is called my-janus. However, if you name the release my-janus-backstage, then the uninstall works.

The root cause is that the item that appears in the "Application Explorer" isn't the Helm release, it's a deployment created by the Helm chart, which is only one of the components making up the Helm release. In order to address this issue, we should list Helm releases in the "Application Explorer" tree view.

You can run helm list -o json to get a JSON list of the Helm releases for the current namespace.

@datho7561 datho7561 self-assigned this Jul 25, 2023
@datho7561 datho7561 added this to the 1.7.0 milestone Jul 25, 2023
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Jul 28, 2023
- Show Helm releases in the project explorer using results from `helm list`
- Add description text for items in the application explorer to helm
  distinguish them
- Refactor Helm commands into their own folder
- Add integration tests for Helm commands

Fixes redhat-developer#3021

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Jul 28, 2023
- Show Helm releases in the project explorer using results from `helm list`
- Add description text for items in the application explorer to help
  distinguish them
- Refactor Helm commands into their own folder
- Add integration tests for Helm commands

Fixes redhat-developer#3021

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 modified the milestones: 1.7.0, 1.6.0 Jul 31, 2023
datho7561 added a commit that referenced this issue Jul 31, 2023
- Show Helm releases in the project explorer using results from `helm list`
- Add description text for items in the application explorer to help
  distinguish them
- Refactor Helm commands into their own folder
- Add integration tests for Helm commands

Fixes #3021

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant