Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Create Service" view #3081

Closed
datho7561 opened this issue Aug 3, 2023 · 0 comments · Fixed by #3435
Closed

Fix "Create Service" view #3081

datho7561 opened this issue Aug 3, 2023 · 0 comments · Fixed by #3435
Assignees
@datho7561
Labels
kind/bug
Milestone
1.10.0

Comments

@datho7561
Copy link
Contributor

Here are some things that I think should be fixed:

  • react-jsonschema-form has "theming" functionality, where you can use form components from a particular component library. We should use the material ui theme to align with the test of the extension
  • The current method of opening the form is hard to find. We should put it somewhere easy to find, such as in the OpenShift Explorer view
    • In order to facilitate this, we will need to add another "page" to the form where the user selects what service they want to create before specifying the details for the service
  • Many of the services you can create have a lot of unrequired properties in the JSON schema. There is a bug where unrequired boolean values are set to false instead of undefined. It would be nice to make sure these cases work properly. It would also be nice to potentially hide the unrequired properties, so that the forms are shorter (the user can always go back and configure them further
@datho7561 datho7561 self-assigned this Sep 27, 2023
@datho7561 datho7561 added this to the 1.10.0 milestone Sep 27, 2023
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Oct 13, 2023
@datho7561
Fix create service webview
dfacfab 
- Move the create service button from the Kubernetes tree
  to the context menu for the cluster
- Add a page to the wizard to select which CustomResourceDefinition
  (CRD) to create an instance of,
  in lieu of using the Kubernetes tree to select the CRD
  - Show the documentation for the Operator that corresponds with the
    CRD on this page,
    since many Operators require additional post-installation steps
    before their associated CRDs work as expected
- Material UI 5 -ify the form page
- Add a Patternfly-like collpase widget for displaying nested objects
- Remove properties from the schema if they are not required and aren't
  configured in the example YAML
- If the user doesn't have access to list CRDs,
  drop them into a YAML editor with the example YAML for the CRD
  - We used to try to scrape the schema for the CRD from the swagger definitions,
    but I removed this, since the schema in the swagger definitions is
    often missing many properties and requires further processing to get
    it to work with React JsonSchema Form

Fixes redhat-developer#3081

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Oct 13, 2023
Merged
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Oct 16, 2023
@datho7561
Fix create service webview
2bc907d 
- Move the create service button from the Kubernetes tree
  to the context menu for the cluster
- Add a page to the wizard to select which CustomResourceDefinition
  (CRD) to create an instance of,
  in lieu of using the Kubernetes tree to select the CRD
  - Show the documentation for the Operator that corresponds with the
    CRD on this page,
    since many Operators require additional post-installation steps
    before their associated CRDs work as expected
- Material UI 5 -ify the form page
- Add a Patternfly-like collpase widget for displaying nested objects
- Remove properties from the schema if they are not required and aren't
  configured in the example YAML
- If the user doesn't have access to list CRDs,
  drop them into a YAML editor with the example YAML for the CRD
  - We used to try to scrape the schema for the CRD from the swagger definitions,
    but I removed this, since the schema in the swagger definitions is
    often missing many properties and requires further processing to get
    it to work with React JsonSchema Form

Fixes redhat-developer#3081

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Oct 26, 2023
@datho7561
Fix create service webview
180f93d 
- Move the create service button from the Kubernetes tree
  to the context menu for the cluster
- Add a page to the wizard to select which CustomResourceDefinition
  (CRD) to create an instance of,
  in lieu of using the Kubernetes tree to select the CRD
  - Show the documentation for the Operator that corresponds with the
    CRD on this page,
    since many Operators require additional post-installation steps
    before their associated CRDs work as expected
- Material UI 5 -ify the form page
- Add a Patternfly-like collpase widget for displaying nested objects
- Remove properties from the schema if they are not required and aren't
  configured in the example YAML
- If the user doesn't have access to list CRDs,
  drop them into a YAML editor with the example YAML for the CRD
  - We used to try to scrape the schema for the CRD from the swagger definitions,
    but I removed this, since the schema in the swagger definitions is
    often missing many properties and requires further processing to get
    it to work with React JsonSchema Form

Fixes redhat-developer#3081

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit that referenced this issue Oct 30, 2023
@datho7561
Fix create service webview
4738fda 
- Move the create service button from the Kubernetes tree
  to the context menu for the cluster
- Add a page to the wizard to select which CustomResourceDefinition
  (CRD) to create an instance of,
  in lieu of using the Kubernetes tree to select the CRD
  - Show the documentation for the Operator that corresponds with the
    CRD on this page,
    since many Operators require additional post-installation steps
    before their associated CRDs work as expected
- Material UI 5 -ify the form page
- Add a Patternfly-like collpase widget for displaying nested objects
- Remove properties from the schema if they are not required and aren't
  configured in the example YAML
- If the user doesn't have access to list CRDs,
  drop them into a YAML editor with the example YAML for the CRD
  - We used to try to scrape the schema for the CRD from the swagger definitions,
    but I removed this, since the schema in the swagger definitions is
    often missing many properties and requires further processing to get
    it to work with React JsonSchema Form

Fixes #3081

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
kind/bug
Projects
IDE Cloudaptors
Archived in project
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Fix create service webview datho7561/vscode-openshift-tools
1 participant
@datho7561