Why is the dependency on vscode-kubernetes added during release?

[datho7561]

Can we switch to recommending vscode-kubernetes instead of requiring it?

If not, can we add this dependency to the package.json so that it's also required when developing/debugging the extension?

First brought up by @rgrunber

[mohitsuman]

For vscode k8s extension, it is added as a dependency for the OpenShift extension which works on the APIs available by the K8s extension. I remember it was added as a dependency on start, but maybe we removed in past releases. We can see if that is needed for us or not.

[rgrunber]

I guess we should check if adding it produces any test failures..

Unfortunately it does.

$ npm test
...
  6 failing
  1) Extension activation
       Extension is activated:
     Error: command 'openshift.output' not found
      at y.k (vscode-file://vscode-app/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/.vscode-test/vscode-linux-x64-1.81.1/resources/app/out/vs/workbench/workbench.desktop.main.js:1510:12265)
      at y.executeCommand (vscode-file://vscode-app/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/.vscode-test/vscode-linux-x64-1.81.1/resources/app/out/vs/workbench/workbench.desktop.main.js:1510:12194)

  2) openshift toolkit Extension
       should register all extension commands declared commands in package descriptor:

      Command 'openshift.about' handler is not registered during activation
      + expected - actual

      -false
      +true
      
      at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/test/unit/extension.test.ts:113:127
      at Array.forEach (<anonymous>)
      at Context.<anonymous> (test/unit/extension.test.ts:112:42)
      at Generator.next (<anonymous>)
      at fulfilled (out/test/unit/extension.test.js:9:58)

  3) openshift toolkit Extension
       async command wrapper shows message returned from command:
     Error: command 'openshift.project.delete' not found
      at y.k (vscode-file://vscode-app/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/.vscode-test/vscode-linux-x64-1.81.1/resources/app/out/vs/workbench/workbench.desktop.main.js:1510:12265)
      at y.executeCommand (vscode-file://vscode-app/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/.vscode-test/vscode-linux-x64-1.81.1/resources/app/out/vs/workbench/workbench.desktop.main.js:1510:12194)

  4) openshift toolkit Extension
       async command wrapper shows error message from rejected command:
     Error: command 'openshift.project.delete' not found
      at y.k (vscode-file://vscode-app/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/.vscode-test/vscode-linux-x64-1.81.1/resources/app/out/vs/workbench/workbench.desktop.main.js:1510:12265)
      at y.executeCommand (vscode-file://vscode-app/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/.vscode-test/vscode-linux-x64-1.81.1/resources/app/out/vs/workbench/workbench.desktop.main.js:1510:12194)

  5) TokenStore
       setUserName
         should set user's name:
     TypeError: Cannot read properties of undefined (reading 'globalState')
      at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/test/unit/util/credentialManager.test.ts:47:83
      at Generator.next (<anonymous>)
      at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/test/unit/util/credentialManager.test.js:12:71
      at new Promise (<anonymous>)
      at __awaiter (out/test/unit/util/credentialManager.test.js:8:12)
      at Context.<anonymous> (test/unit/util/credentialManager.test.ts:46:52)
      at processImmediate (node:internal/timers:466:21)

  6) TokenStore
       getUserName
         should get user's name:
     TypeError: Cannot read properties of undefined (reading 'globalState')
      at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/test/unit/util/credentialManager.test.ts:56:70
      at Generator.next (<anonymous>)
      at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/test/unit/util/credentialManager.test.js:12:71
      at new Promise (<anonymous>)
      at __awaiter (out/test/unit/util/credentialManager.test.js:8:12)
      at Context.<anonymous> (test/unit/util/credentialManager.test.ts:55:52)
      at processImmediate (node:internal/timers:466:21)

...
Test failures: 6

Running integration tests doesn't produce any failures.

[vrubezhny]

Highly likely, the reason is: