Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree item in the Serverless Functions view keeps name of the latest used project #3145

Closed
lgrossma opened this issue Aug 30, 2023 · 8 comments · Fixed by #3241
Closed

Tree item in the Serverless Functions view keeps name of the latest used project #3145

lgrossma opened this issue Aug 30, 2023 · 8 comments · Fixed by #3241
Assignees
Labels
Milestone

Comments

@lgrossma
Copy link
Contributor

Tree item in the Serverless Functions view changes its name depending on the name of the project that is currently used. After deleting all projects on cluster or loggin off the cluster, the tree item in Serverless functions view keeps the name of the latest used project.
Screenshot 2023-08-30 at 14 58 58

@msivasubramaniaan
Copy link
Collaborator

@lgrossma
Yes it is always pointed to latest namespace based on .kube config file. When user switches to different namespace then tree automatically get refreshed.

@lgrossma
Copy link
Contributor Author

Sounds as a correct behaviour when user switches namespaces, but I was pointing to a case when user loggs off or deletes all namespaces - in this case, shouldn't the tree item be set to it's default value?

@msivasubramaniaan
Copy link
Collaborator

Sounds as a correct behaviour when user switches namespaces, but I was pointing to a case when user loggs off or deletes all namespaces - in this case, shouldn't the tree item be set to it's default value?

Post deletion of the namespace, What will be the namespace value of current context in .kube config file?

@lgrossma
Copy link
Contributor Author

The current context in the .kube file stays the same as before deletion (the latest namespace). But if I delete all namespaces (projects) from my cluster or log out, I don't see a reason to why should I still see the namespace in the serverless functions tree item.

@msivasubramaniaan
Copy link
Collaborator

As part of serverless function workflow, There are three types:

  1. Local
  2. Cluster
  3. Local/Cluster

We have to provide an option to create function even though there were no cluster/namespaces. So for incorporating the above local workflow we are showing the latest namespace. And user can create a function under on it.

@lgrossma
Copy link
Contributor Author

I understand that workflow. It just does not make sense to me to use the latest namespace, when there is none. For me as a user, it kinda seemed as a bug that after deleting all projects or logging out the tree item label did not switch back to it's default value..

@datho7561
Copy link
Contributor

@rgrunber mentioned that we should be able to create a serverless function without providing a namespace, so we shouldn't use the last available namespace to create the serverless function.

Do we need to show the current namespace in the Serverless Functions view at all? We are already showing it in the application explorer view.

@msivasubramaniaan
Copy link
Collaborator

@rgrunber mentioned that we should be able to create a serverless function without providing a namespace, so we shouldn't use the last available namespace to create the serverless function.

Do we need to show the current namespace in the Serverless Functions view at all? We are already showing it in the application explorer view.

I think we can removed the current namespace from Serverless Functions view.

@datho7561 datho7561 added this to the 1.8.0 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment