Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed current namespace from serverless function tree view #3241

Conversation

msivasubramaniaan
Copy link
Collaborator

Fixes: #3145

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.28% ⚠️

Comparison is base (fa9a012) 37.56% compared to head (81e52b6) 37.29%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
- Coverage   37.56%   37.29%   -0.28%     
==========================================
  Files          77       77              
  Lines        5271     5248      -23     
  Branches     1000      993       -7     
==========================================
- Hits         1980     1957      -23     
  Misses       3291     3291              
Files Changed Coverage Δ
src/serverlessFunction/functions.ts 4.33% <0.00%> (-0.07%) ⬇️
src/serverlessFunction/view.ts 34.82% <0.00%> (-6.03%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/serverlessFunction/view.ts Outdated Show resolved Hide resolved
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561
Copy link
Contributor

There is also this file watcher, which I think is only used to track the current namespace: https://github.com/redhat-developer/vscode-openshift-tools/pull/3241/files#diff-7b252f53014e39d3101cc51d5a916d9da0cddcc8467c63aa901db00a85ee2c61R68

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Muthu!

@datho7561
Copy link
Contributor

(waiting for CI)

@datho7561 datho7561 merged commit 2ed70dc into redhat-developer:main Sep 8, 2023
4 of 6 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3145-tree-item-in-the-serverless-functions-view-keeps-name-of-the-latest-used-project branch September 8, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree item in the Serverless Functions view keeps name of the latest used project
2 participants