Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Kubernetes extension commands #3990

Closed
msivasubramaniaan opened this issue Mar 18, 2024 · 2 comments · Fixed by #4106
Closed

Migrate Kubernetes extension commands #3990

msivasubramaniaan opened this issue Mar 18, 2024 · 2 comments · Fixed by #4106
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@msivasubramaniaan
Copy link
Collaborator

msivasubramaniaan commented Mar 18, 2024

Replace extension.vsKubernetesLoad, extension.vsKubernetesUseNamespace command functionality

Ref: #3981

@msivasubramaniaan msivasubramaniaan added the kind/enhancement New feature or request label Mar 18, 2024
@msivasubramaniaan msivasubramaniaan added this to the 1.13.0 milestone Mar 18, 2024
@msivasubramaniaan msivasubramaniaan self-assigned this Mar 18, 2024
@msivasubramaniaan msivasubramaniaan moved this to 🏗 In progress in IDE Cloudaptors Mar 18, 2024
@msivasubramaniaan msivasubramaniaan moved this from 🏗 In progress to 📋 Backlog in IDE Cloudaptors Mar 18, 2024
@msivasubramaniaan msivasubramaniaan changed the title Migrate extension.vsKubernetesLoad command Migrate Kubernetes extension commands Mar 18, 2024
@mohitsuman mohitsuman modified the milestones: 1.13.0, 1.14.0 Apr 2, 2024
@vrubezhny
Copy link
Contributor

vrubezhny commented Apr 22, 2024

It doesn't look like we really need anything to do with extension.vsKubernetesUseNamespace - we use openshift.project.set to set/change active namespace/project from Command Palette/Status Bar/Context menu.
I believe we can just remove any extension.vsKubernetesUseNamespace registrations/references as not used.

@vrubezhny
Copy link
Contributor

vrubezhny commented Apr 23, 2024

For the extension.vsKubernetesLoad command we already have a replacement: openshift.resource.load. The only problem here is that when we remove the k8s extension dependency then we get rid of KubernetesResourceVirtualFileSystemProvider virtual file system provider that, as far as I understand, is registered by the k8s extension to respond to URI requests to load deployment/pod/etc. yaml-files like k8smsx(ro)?://loadkubernetescore/, k8smsx(ro)?://kubernetesdescribe/, k8smsx(ro)?://helmget/ - so we have to add this virtual file system provider to vscode openshift tools in order to make it working correctly without having the k8s extension installed.
However some other modifications/fixes might be also required, f.i., Implement Port Forward IU (add/remove/show related information) #3906

@vrubezhny vrubezhny moved this from 📋 Backlog to 🏗 In progress in IDE Cloudaptors Apr 25, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 8, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 8, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 8, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 8, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 8, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors May 8, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 8, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 8, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 9, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 9, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 9, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 9, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 9, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 9, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 9, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 10, 2024
Fixes: redhat-developer#3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
datho7561 pushed a commit that referenced this issue May 10, 2024
Fixes: #3990

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: ✅ Done
3 participants