-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension is slow to activate #4226
Comments
We need to look at the events getting activated together when making calls |
@datho7561 @vrubezhny @msivasubramaniaan maybe we need to load each view separately instead of loading all at once. |
The PR adds some optimization to the extension activation. Also, the PR removes funcion 'migrateFromOdo018' which looks over outdated and doesn't make its work properly after a nomerous changes in ODO. See: redhat-developer#4255 Fixes: redhat-developer#4255 Issue: redhat-developer#4226 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
The PR adds some optimization to the extension activation. Also, the PR removes function 'migrateFromOdo018' which looks over outdated and doesn't make its work properly after a numerous changes in ODO. See: redhat-developer#4255 Fixes: redhat-developer#4255 Issue: redhat-developer#4226 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
The PR adds some optimization to the extension activation. Also, the PR removes function 'migrateFromOdo018' which looks over outdated and doesn't make its work properly after a numerous changes in ODO. See: redhat-developer#4255 Fixes: redhat-developer#4255 Issue: redhat-developer#4226 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
The PR adds some optimization to the extension activation. Also, the PR removes function 'migrateFromOdo018' which looks over outdated and doesn't make its work properly after a numerous changes in ODO. See: redhat-developer#4255 Fixes: redhat-developer#4255 Issue: redhat-developer#4226 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
The PR adds some optimization to the extension activation. Also, the PR removes function 'migrateFromOdo018' which looks over outdated and doesn't make its work properly after a numerous changes in ODO. See: redhat-developer#4255 Fixes: redhat-developer#4255 Fixes: redhat-developer#4226 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@fbricon Could you please give it a try once again (using the main branch or by installing a VSIX built from the main branch)? Feel free to reopen the issue in case it's still too slow on activate. Thanks! |
Running from main, the bundled extension is still quite slow to activate (from 300ms to 1000ms) One potential hint is this message when running
Indeed, the zip contains a shitload of .js files, that we should bundle with webpack or eslint: |
OpenShift toolkit is the slowest of all the extensions I have installed. Taking between 300ms and almost 900ms to activate, on my MBP Pro M3.
The text was updated successfully, but these errors were encountered: