Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use users home folder as current directory when deleting service #1046

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

dgolovin
Copy link
Collaborator

Fix #1038.

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #1046 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage    85.9%   85.85%   -0.05%     
==========================================
  Files          30       30              
  Lines        1972     1973       +1     
  Branches      343      343              
==========================================
  Hits         1694     1694              
- Misses        278      279       +1
Impacted Files Coverage Δ
src/odo.ts 84.64% <ø> (ø) ⬆️
src/util/watch.ts 96.55% <0%> (-3.45%) ⬇️
src/openshift/service.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4f7be...146f28e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #1046 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage    85.9%   85.85%   -0.05%     
==========================================
  Files          30       30              
  Lines        1972     1973       +1     
  Branches      343      343              
==========================================
  Hits         1694     1694              
- Misses        278      279       +1
Impacted Files Coverage Δ
src/odo.ts 84.64% <ø> (ø) ⬆️
src/util/watch.ts 96.55% <0%> (-3.45%) ⬇️
src/openshift/service.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4f7be...146f28e. Read the comment docs.

@dgolovin dgolovin merged commit 0826579 into redhat-developer:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete service command fails
1 participant