Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary file list from context folder in the quickPick #1113

Merged
merged 8 commits into from
Sep 3, 2019

Conversation

mohitsuman
Copy link
Collaborator

Fix #1055

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1113 into master will decrease coverage by 1.27%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   85.09%   83.81%   -1.28%     
==========================================
  Files          31       31              
  Lines        2087     2095       +8     
  Branches      362      362              
==========================================
- Hits         1776     1756      -20     
- Misses        311      339      +28
Impacted Files Coverage Δ
src/odo.ts 82.65% <0%> (-1.64%) ⬇️
src/openshift/component.ts 84.91% <66.66%> (-5.71%) ⬇️
src/util/watch.ts 96.55% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac6307...68d8174. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1113 into master will decrease coverage by 0.98%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   85.09%   84.11%   -0.99%     
==========================================
  Files          31       31              
  Lines        2087     2147      +60     
  Branches      362      375      +13     
==========================================
+ Hits         1776     1806      +30     
- Misses        311      341      +30
Impacted Files Coverage Δ
src/openshift/component.ts 90.9% <95.83%> (+0.29%) ⬆️
src/util/watch.ts 96.55% <0%> (-3.45%) ⬇️
src/odo.ts 80.95% <0%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac6307...5d81fb0. Read the comment docs.

src/openshift/component.ts Outdated Show resolved Hide resolved
src/openshift/component.ts Outdated Show resolved Hide resolved
src/odo.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@mohitsuman mohitsuman merged commit 9226577 into redhat-developer:master Sep 3, 2019
@mohitsuman mohitsuman deleted the gh-1055 branch June 16, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants