Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git+binary workflow fix #1158

Merged
merged 4 commits into from
Sep 13, 2019
Merged

git+binary workflow fix #1158

merged 4 commits into from
Sep 13, 2019

Conversation

mohitsuman
Copy link
Collaborator

@mohitsuman mohitsuman commented Sep 13, 2019 •
edited
Loading

  1. Add context folder selection at start for git workflow
  2. Use workspace.ts for folderSelection for git & binary workflow
  3. Check for component folder already existing at the selected path.

Fix #1159

@mohitsuman
1. Add context folder selection at start for git workflow
a2cf11d 
2. Check for component folder already existing
dgolovin
dgolovin requested changes Sep 13, 2019
View reviewed changes
Copy link
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling file inside util module as workspaceUtil.ts is too much 'util' ;)
Have you checked workspace.ts BTW?

@mohitsuman
Copy link
Collaborator Author

Calling file inside util module as workspaceUtil.ts is too much 'util' ;)
Have you checked workspace.ts BTW?

workspace.ts is renamed as workspaceUtil. As class workspace from vscode was conflicting.

dgolovin
dgolovin reviewed Sep 13, 2019
View reviewed changes
src/util/workspaceUtil.ts Outdated Show resolved Hide resolved
@mohitsuman mohitsuman changed the title git workflow fix git+ binary workflow fix Sep 13, 2019
@mohitsuman mohitsuman changed the title git+ binary workflow fix git+binary workflow fix Sep 13, 2019
dgolovin
dgolovin approved these changes Sep 13, 2019
View reviewed changes
Copy link
Collaborator

@dgolovin dgolovin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitsuman mohitsuman merged commit 79e3a49 into redhat-developer:master Sep 13, 2019
@mohitsuman mohitsuman mentioned this pull request Sep 13, 2019
Closed
@mohitsuman mohitsuman deleted the gh-1140 branch June 16, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgolovin dgolovin dgolovin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

context folder selection for git based workflow
2 participants
@mohitsuman @dgolovin