Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress bar for credentials and token Login #1236

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

sudhirverma
Copy link
Contributor

Fix: #1232

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1236 into master will increase coverage by 3.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1236      +/-   ##
=========================================
+ Coverage   82.64%   85.8%   +3.16%     
=========================================
  Files          32      32              
  Lines        2259    2255       -4     
  Branches      401     401              
=========================================
+ Hits         1867    1935      +68     
+ Misses        392     320      -72
Impacted Files Coverage Δ
src/openshift/cluster.ts 100% <100%> (ø) ⬆️
src/odo.ts 79.43% <0%> (-0.1%) ⬇️
src/k8s/deployment.ts 97.22% <0%> (+1.27%) ⬆️
src/k8s/common.ts 100% <0%> (+3.84%) ⬆️
src/openshift/component.ts 93.52% <0%> (+20.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a145f9f...1f1b6b4. Read the comment docs.

src/openshift/cluster.ts Outdated Show resolved Hide resolved
src/openshift/cluster.ts Outdated Show resolved Hide resolved
@dgolovin dgolovin merged commit 984f337 into redhat-developer:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show progress bar for credentials and token Login
2 participants