Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use vscode open command instead of open module for external links #1254

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

mohitsuman
Copy link
Collaborator

Fix #1249

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #1254 into master will decrease coverage by 0.38%.
The diff coverage is 28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage    85.8%   85.42%   -0.39%     
==========================================
  Files          32       32              
  Lines        2255     2257       +2     
  Branches      401      401              
==========================================
- Hits         1935     1928       -7     
- Misses        320      329       +9
Impacted Files Coverage Δ
src/odo.ts 79.4% <0%> (-0.04%) ⬇️
src/k8s/console.ts 13.55% <0%> (-3.75%) ⬇️
src/tools.ts 93.82% <0%> (-0.08%) ⬇️
src/openshift/cluster.ts 100% <100%> (ø) ⬆️
src/openshift/component.ts 93.51% <100%> (-0.02%) ⬇️
src/openshift/url.ts 96.07% <100%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984f337...313a5d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rely on 'vscode.env.openExternal' API instead of 3'd party lib
2 participants