sandbox form prototype #2317
Merged
sandbox form prototype #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dgolovin
commented
Dec 18, 2021
dgolovin
commented
- POC to provision sandbox
- Prototype of Sandbox integration in Add Cluster editor
Codecov Report
@@ Coverage Diff @@
## master #2317 +/- ##
==========================================
- Coverage 69.84% 66.08% -3.76%
==========================================
Files 51 46 -5
Lines 3412 3288 -124
Branches 629 611 -18
==========================================
- Hits 2383 2173 -210
- Misses 1029 1115 +86
Continue to review full report at Codecov.
|
gorkem
reviewed
Jan 4, 2022
dgolovin
force-pushed
the
i2236-sandbox-form-prototype
branch
from
d4d3253
to
c451ed2
Compare
|
@dgolovin I have fixed the UI for the workflow in the latest 2 commits. The elements to select phone number is through a drop-down now. |
|
We might need to test the phone verification properly again after the changes. And there is one issue in the workflow, if the user during |
|
This is how the first page of the workflow will look. All are working links.
|
|
For the user profile, the information will refer to the currently logged-in user session.
|
This PR related to redhat-developer#2236 Signed-off-by: Denis Golovin dgolovin@redhat.com
Steps to run: * Build webview react app using `npm run dev:compile:cluster-view` * Run `Launch Cluster Editor in Chrome` from `Debug: Select and Start Debugging` palette item Those steps above will include stub for `acquireVsCodeApi()` function (see devstub.js file for implementation) that drives workflow for Sandbox page. This is simple implementation to allow work on UI in parallel with backend. This PR related to redhat-developer#2236. Signed-off-by: Denis Golovin dgolovin@redhat.com
This PR fixes #????. Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Tested with mock serve implemented with nodejs express module. There are still usecases to adress: 1. Connection timieouts 2. Expiration of auth token in the middle of workflow 3. And, of course, proxy support Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin
force-pushed
the
i2236-sandbox-form-prototype
branch
from
c3c175b
to
206574d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.