Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC commands does not work in case of full path has spaces #2320

Merged

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented Jan 7, 2022

This PR fixes #2319.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#2319.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #2320 (889572f) into master (b787b09) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head 889572f differs from pull request most recent head 117ab9c. Consider uploading reports for the commit 117ab9c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
- Coverage   70.10%   69.96%   -0.15%     
==========================================
  Files          51       51              
  Lines        3399     3406       +7     
  Branches      627      628       +1     
==========================================
  Hits         2383     2383              
- Misses       1016     1023       +7     
Impacted Files Coverage Δ
src/webview/cluster/clusterViewLoader.ts 13.23% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b787b09...117ab9c. Read the comment docs.

Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin merged commit fed6247 into redhat-developer:master Jan 10, 2022
dgolovin added a commit that referenced this pull request Jan 11, 2022
* CRC commands does not work in case of full path has spaces

This PR fixes #2319.

Signed-off-by: Denis Golovin dgolovin@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode-OpenShift-tools Folder Issue
1 participant