Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print errors to output channel and show error message notifications #2321

Conversation

dgolovin
Copy link
Collaborator

This PR related to #2319.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR related to redhat-developer#2319.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #2321 (4e7da83) into master (fed6247) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2321      +/-   ##
==========================================
- Coverage   69.96%   69.84%   -0.13%     
==========================================
  Files          51       51              
  Lines        3406     3412       +6     
  Branches      628      629       +1     
==========================================
  Hits         2383     2383              
- Misses       1023     1029       +6     
Impacted Files Coverage Δ
src/webview/cluster/clusterViewLoader.ts 12.67% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed6247...4e7da83. Read the comment docs.

@dgolovin dgolovin merged commit 05ba033 into redhat-developer:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant