Preserve mohitsuman commits #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR related to redhat-developer#2236 Signed-off-by: Denis Golovin dgolovin@redhat.com
Steps to run: * Build webview react app using `npm run dev:compile:cluster-view` * Run `Launch Cluster Editor in Chrome` from `Debug: Select and Start Debugging` palette item Those steps above will include stub for `acquireVsCodeApi()` function (see devstub.js file for implementation) that drives workflow for Sandbox page. This is simple implementation to allow work on UI in parallel with backend. This PR related to redhat-developer#2236. Signed-off-by: Denis Golovin dgolovin@redhat.com
This PR fixes #????. Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Tested with mock serve implemented with nodejs express module. There are still usecases to adress: 1. Connection timieouts 2. Expiration of auth token in the middle of workflow 3. And, of course, proxy support Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
Codecov Report
@@ Coverage Diff @@
## master #2328 +/- ##
=======================================
Coverage 66.08% 66.08%
=======================================
Files 46 46
Lines 3288 3288
Branches 611 611
=======================================
Hits 2173 2173
Misses 1115 1115 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.