Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout configuration for Sandbox Registration Service Requests #2337

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented Feb 3, 2022

This PR fixes #2335.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#2335.

Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #2337 (1316b47) into master (d6a4ef5) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
- Coverage   65.51%   65.50%   -0.01%     
==========================================
  Files          46       46              
  Lines        3323     3325       +2     
  Branches      612      612              
==========================================
+ Hits         2177     2178       +1     
- Misses       1146     1147       +1     
Impacted Files Coverage Δ
src/odo.ts 65.43% <ø> (ø)
src/openshift/sandbox.ts 56.52% <33.33%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a4ef5...1316b47. Read the comment docs.

@dgolovin dgolovin merged commit 2a96ec3 into redhat-developer:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Timeout setting for Sandbox integration
1 participant