Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switch and delete icons on manage contexts show-pick and done refactoring #2684

Merged
merged 18 commits into from
Nov 29, 2022

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented Nov 29, 2022

Fixes #2598.

  • added switch and delete icons on manage contexts show-pick and done refactoring
  • merge main branch
  • added kubeconfig tree item into app explorer and open kubeconfig file command
  • changed tooltip value
  • reverted kubeconfig file info on tree item
  • remove unused import
  • changed odo initialization
  • added onDidAccept listener for getting selected value from quick pick
  • title changed
  • removed await
  • addressed the review comments
  • Add error handling to switch context command execution
  • Resolve switch context command to null when cancelled by user

msivasubramaniaan and others added 18 commits November 4, 2022 11:26
…efactoring

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
… command

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: Denis Golovin dgolovin@redhat.com
This is important for telemetry to report cancellation event

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 34.53% // Head: 34.34% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (29067d8) compared to base (8382031).
Patch coverage: 2.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
- Coverage   34.53%   34.34%   -0.19%     
==========================================
  Files          68       68              
  Lines        4019     4041      +22     
  Branches      714      715       +1     
==========================================
  Hits         1388     1388              
- Misses       2631     2653      +22     
Impacted Files Coverage Δ
src/odo/command.ts 18.58% <0.00%> (-0.25%) ⬇️
src/util/kubeUtils.ts 54.23% <ø> (ø)
src/openshift/cluster.ts 11.20% <2.94%> (-0.98%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dgolovin dgolovin changed the title i2598 Added switch and delete icons on manage contexts show-pick and done refactoring Nov 29, 2022
@dgolovin dgolovin merged commit 4b8924e into redhat-developer:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Kubernetes Context Action
2 participants