Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide commands that require selecting a component #2801

Conversation

datho7561
Copy link
Contributor

The commands are still accessible in the relevant right-click menus, but are no longer available in the command palette, since they don't work when invoked from the command palette.

This is a work around until we can get the commands to work from the command palette when working with OpenShift Dev Sandbox.

Fixes #2792

Signed-off-by: David Thompson davthomp@redhat.com

@datho7561 datho7561 marked this pull request as ready for review March 20, 2023 18:37
@rgrunber rgrunber self-requested a review April 4, 2023 04:28
The commands are still accessible in the relevant right-click menus,
but are no longer available in the command palette,
since they don't work when invoked from the command palette.

This is a work around until we can get the commands to work from the
command palette when working with OpenShift Dev Sandbox.

Fixes redhat-developer#2792

Signed-off-by: David Thompson <davthomp@redhat.com>
@rgrunber rgrunber force-pushed the 2792-hide-component-commands-from-palette branch from 42eba8d to 46d3d9b Compare April 11, 2023 19:05
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9daef3e) 34.09% compared to head (eb63425) 34.09%.

❗ Current head eb63425 differs from pull request most recent head 46d3d9b. Consider uploading reports for the commit 46d3d9b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2801   +/-   ##
=======================================
  Coverage   34.09%   34.09%           
=======================================
  Files          70       70           
  Lines        4320     4320           
  Branches      777      777           
=======================================
  Hits         1473     1473           
  Misses       2847     2847           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rgrunber rgrunber merged commit 3971484 into redhat-developer:main Apr 11, 2023
@rgrunber rgrunber added this to the 1.3.0 milestone Apr 11, 2023
@datho7561 datho7561 deleted the 2792-hide-component-commands-from-palette branch April 11, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When connected to DevSandbox, "OpenShift: Start Dev" results in error
2 participants