Remove the old service create/delete commands #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgrunber if you have time, could you please review this PR? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
==========================================
+ Coverage 33.49% 33.77% +0.28%
==========================================
Files 56 55 -1
Lines 4117 4059 -58
Branches 779 768 -11
==========================================
- Hits 1379 1371 -8
+ Misses 2738 2688 -50
☔ View full report in Codecov by Sentry. |
|
okay should be good! |
datho7561
force-pushed
the
2841-remove-old-service-commands
branch
from
c6e3535
to
797af89
Compare
rgrunber
reviewed
May 1, 2023
datho7561
force-pushed
the
2841-remove-old-service-commands
branch
from
797af89
to
6852b93
Compare
rgrunber
previously approved these changes
May 1, 2023
The old commands no longer work. They have been replaced with a webview that provides a nice form to create a service (that also doesn't work but will take a lot of time to fix). Removing this code will result in less to test for redhat-developer#2799. Part of redhat-developer#2841 Signed-off-by: David Thompson <davthomp@redhat.com>
rgrunber
force-pushed
the
2841-remove-old-service-commands
branch
from
6852b93
to
ab93371
Compare
datho7561
added a commit
to datho7561/vscode-openshift-tools
that referenced
this pull request
May 19, 2023
- remove unused commands from `commands.ts` and unused methods from
`odo.ts`
- Notably, remove `ODO.getApplications()`, `ODO.getComponents()`,
and the in-memory tree representing the cluster state,
since they don't work properly and we have replacements for them
- rewrite integration tests for `commands.ts` and `odo.ts`
- report test coverage for integration tests
- add the integration tests to the UI test Jenkinsfile workflow
Depends on redhat-developer#2865, redhat-developer#2863, redhat-developer#2862
Fixes redhat-developer#2799
Signed-off-by: David Thompson <davthomp@redhat.com>
rgrunber
pushed a commit
that referenced
this pull request
May 19, 2023
- remove unused commands from `commands.ts` and unused methods from
`odo.ts`
- Notably, remove `ODO.getApplications()`, `ODO.getComponents()`,
and the in-memory tree representing the cluster state,
since they don't work properly and we have replacements for them
- rewrite integration tests for `commands.ts` and `odo.ts`
- report test coverage for integration tests
- add the integration tests to the UI test Jenkinsfile workflow
Depends on #2865, #2863, #2862
Fixes #2799
Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old commands no longer work. They have been replaced with a webview that provides a nice form to create a service (that also doesn't work but will take a lot of time to fix). Removing this code will result in less to test for #2799.
Part of #2841
Signed-off-by: David Thompson davthomp@redhat.com