Increase timeouts for "Import from Git" UI test #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2876 +/- ##
==========================================
+ Coverage 33.77% 35.22% +1.44%
==========================================
Files 55 55
Lines 4059 4063 +4
Branches 768 763 -5
==========================================
+ Hits 1371 1431 +60
+ Misses 2688 2632 -56
☔ View full report in Codecov by Sentry. |
datho7561
force-pushed
the
increase-git-import-timeout
branch
from
a1ac5d4 to
2e33e60
Compare
|
How the heck could I possibly be increasing code coverage? That makes no sense. |
datho7561
force-pushed
the
increase-git-import-timeout
branch
from
2e33e60 to
b729818
Compare
Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
increase-git-import-timeout
branch
from
b729818 to
1fce587
Compare
|
I double checked, and the coverage is not actually increasing (if I get the coverage from running |
|
@rgrunber if you have time, could you please take a look at this PR? |
rgrunber
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Thompson davthomp@redhat.com