Add 'Show welcome page on startup' checkbox

[JessicaJHee]

Fixes #2552

• Also fixes a distorted image in the welcome page

[codecov]

Codecov Report

Patch coverage: 90.00% and project coverage change: +1.56 🎉

Comparison is base (3a18ed6) 35.22% compared to head (5a0af44) 36.78%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   35.22%   36.78%   +1.56%     
==========================================
  Files          55       53       -2     
  Lines        4063     3681     -382     
  Branches      763      715      -48     
==========================================
- Hits         1431     1354      -77     
+ Misses       2632     2327     -305     

Impacted Files	Coverage Δ
src/telemetry.ts	60.00% <ø> (ø)
src/webview/welcome/welcomeViewLoader.ts	70.49% <90.00%> (+3.82%)	⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[datho7561]

Looking good so far, one comment about the styling

[mohitsuman]

@JessicaJHee I would move this checkbox to the end of the page below the Documentation section and would also like to capture telemetry of usage of the check/uncheck action. (can do telemetry one as a separate issue).

[JessicaJHee]

@mohitsuman I've added telemetry for this with welcomePage as the action name and showWelcomePage: boolean as an event property. Please let me know if this is the correct idea!

[datho7561]

One more small thing I noticed; if you have the OpenShift welcome page set to not show on startup, but then open it later through the command (OpenShift: Welcome), then the checkbox is checked, even though the setting is set to not show the page.

[JessicaJHee]

One more small thing I noticed; if you have the OpenShift welcome page set to not show on startup, but then open it later through the command (OpenShift: Welcome), then the checkbox is checked, even though the setting is set to not show the page.

Should be fixed now, thanks!

[datho7561]

Looks good and works well for me! Thanks Jessica!

[mohitsuman]

LGTM