Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all path separators #2907

Merged

Conversation

datho7561
Copy link
Contributor

Fixes #2894

Signed-off-by: David Thompson davthomp@redhat.com

Fixes redhat-developer#2894

Signed-off-by: David Thompson <davthomp@redhat.com>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.08 ⚠️

Comparison is base (452abdd) 36.74% compared to head (1376ebd) 36.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
- Coverage   36.74%   36.67%   -0.08%     
==========================================
  Files          53       53              
  Lines        3671     3670       -1     
  Branches      712      712              
==========================================
- Hits         1349     1346       -3     
- Misses       2322     2324       +2     
Impacted Files Coverage Δ
src/openshift/component.ts 20.00% <50.00%> (-0.20%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitsuman mohitsuman merged commit bdf500f into redhat-developer:main May 24, 2023
@datho7561 datho7561 deleted the 2894-fix-path-conversion branch May 24, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Incomplete string escaping or encoding
3 participants