Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all the devfiles when no devfile.yaml in the git repo #2943

Conversation

msivasubramaniaan
Copy link
Collaborator

Signed-off-by: msivasubramaniaan msivasub@redhat.com

Fix: #2939

When no devfile.yaml/language specific code were detects, then the git import showed all the list of devfiles from the registry. User can pick any one. Please refer below:
no-devfile-demo

Handling the devfile with dropdown will be part of the #2697

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (be34e3f) 37.32% compared to head (4951304) 37.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
+ Coverage   37.32%   37.34%   +0.02%     
==========================================
  Files          54       54              
  Lines        3652     3655       +3     
  Branches      716      717       +1     
==========================================
+ Hits         1363     1365       +2     
- Misses       2289     2290       +1     
Impacted Files Coverage Δ
src/webview/git-import/gitImportLoader.ts 16.46% <0.00%> (-0.21%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, Muthu!

@datho7561
Copy link
Contributor

datho7561 commented Jun 6, 2023

Unit tests fail (for me at least) I figured out why, I didn't have a current kube context

@datho7561
Copy link
Contributor

@msivasubramaniaan feel free to merge if you think it's good to go

@mohitsuman mohitsuman merged commit fd1ea8d into redhat-developer:main Jun 6, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2939-cloning-a-repo-without-any-code-fails-with-incorrect-message branch June 6, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning a repo without any code fails with incorrect message
3 participants