Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide deleteConfigurationFiles and deleteSourceFolder option when running #2946

Merged

Conversation

JessicaJHee
Copy link
Contributor

Fixes #2927

…onent is running

Signed-off-by: Jessica He <jhe@redhat.com>
Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.28 ⚠️

Comparison is base (a5dd2b7) 37.37% compared to head (73fe0f5) 37.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
- Coverage   37.37%   37.10%   -0.28%     
==========================================
  Files          54       54              
  Lines        3652     3652              
  Branches      716      716              
==========================================
- Hits         1365     1355      -10     
- Misses       2287     2297      +10     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@msivasubramaniaan msivasubramaniaan merged commit 8113c72 into redhat-developer:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete component configuration does not stop odo
3 participants